From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LAQaw-0007ah-6j for qemu-devel@nongnu.org; Wed, 10 Dec 2008 10:03:22 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LAQav-0007ZQ-Fq for qemu-devel@nongnu.org; Wed, 10 Dec 2008 10:03:21 -0500 Received: from [199.232.76.173] (port=58882 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAQav-0007ZD-Bx for qemu-devel@nongnu.org; Wed, 10 Dec 2008 10:03:21 -0500 Received: from hall.aurel32.net ([88.191.82.174]:41437) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LAQau-0007LV-M8 for qemu-devel@nongnu.org; Wed, 10 Dec 2008 10:03:21 -0500 Received: from lneuilly-152-21-37-9.w193-253.abo.wanadoo.fr ([193.253.214.9] helo=volta.aurel32.net) by hall.aurel32.net with esmtpsa (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1LAQat-0008A3-FS for qemu-devel@nongnu.org; Wed, 10 Dec 2008 16:03:19 +0100 Received: from aurel32 by volta.aurel32.net with local (Exim 4.69) (envelope-from ) id 1LAQas-0006qi-NS for qemu-devel@nongnu.org; Wed, 10 Dec 2008 16:03:18 +0100 Date: Wed, 10 Dec 2008 16:03:18 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] Fix memory-mapped i8042 on MIPS Magnum v3 Message-ID: <20081210150318.GC19379@volta.aurel32.net> References: <493D9A7B.80801@reactos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <493D9A7B.80801@reactos.org> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Mon, Dec 08, 2008 at 11:06:51PM +0100, Hervé Poussineau wrote: > Hi, > > Current implementation of memory-mapped i8042 controller is atm > implemented with an interface shift (it_shift) parameter, like most all > memory-mapped devices in Qemu. > However, this isn't suitable for MIPS Magnum, where i8042 controller is > at 0x80005000 up to 0x80005fff. > > Thomas Bogendoerfer (from #mipslinux) tested the behaviour of a real > machine, and found that odd addresses are for status/command register, > and even addresses for data register. > > Attached patch implements this behaviour by replacing the it_shift > parameter by a mask one. > Incidentally, keyboard now works on OpenBSD 2.3, which accesses i8042 > controller at 0x80005060 and 0x80005061. > > Signed-off-by: Hervé Poussineau > Thanks, applied. -- .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 : :' : Debian developer | Electrical Engineer `. `' aurel32@debian.org | aurelien@aurel32.net `- people.debian.org/~aurel32 | www.aurel32.net