[Qemu-devel] [PATCH] IDE: Implement SEEK command (resend)

[Qemu-devel] [PATCH] IDE: Implement SEEK command (resend)

[Justin Chevrier]

Resend original patch with correct Signed-off-by. Original text below.


Openserver issues a SEEK command during initial drive detection. It refuses to report the hard drive if this command fails. This patch gets Openserver to list the hard drive but installation still fails (freezes) later on due to an unrelated IDE issue (patch on its way).

Justin

Changelog:

Implement SEEK command

Signed-off-by: Justin Chevrier <theburner1@yahoo.com>

Index: hw/ide.c
===================================================================
--- hw/ide.c    (revision 5948)
+++ hw/ide.c    (working copy)
@@ -2324,6 +2324,13 @@
             s->status = READY_STAT;
             ide_set_irq(s);
             break;
+        case WIN_SEEK:
+            if(s->is_cdrom)
+                goto abort_cmd;
+            /* XXX: Check that seek is within bounds */
+            s->status = READY_STAT | SEEK_STAT;
+            ide_set_irq(s);
+            break;
             /* ATAPI commands */
         case WIN_PIDENTIFY:
             if (s->is_cdrom) {


      

Re: [Qemu-devel] [PATCH] IDE: Implement SEEK command (resend)

[Aurelien Jarno]

On Wed, Dec 10, 2008 at 07:44:04AM -0800, Justin Chevrier wrote:
> Resend original patch with correct Signed-off-by. Original text below.
> 
> 
> Openserver issues a SEEK command during initial drive detection. It refuses to report the hard drive if this command fails. This patch gets Openserver to list the hard drive but installation still fails (freezes) later on due to an unrelated IDE issue (patch on its way).
> 
> Justin
> 
> Changelog:
> 
> Implement SEEK command
> 
> Signed-off-by: Justin Chevrier <theburner1@yahoo.com>

Thanks, applied.

> Index: hw/ide.c
> ===================================================================
> --- hw/ide.c    (revision 5948)
> +++ hw/ide.c    (working copy)
> @@ -2324,6 +2324,13 @@
>              s->status = READY_STAT;
>              ide_set_irq(s);
>              break;
> +        case WIN_SEEK:
> +            if(s->is_cdrom)
> +                goto abort_cmd;
> +            /* XXX: Check that seek is within bounds */
> +            s->status = READY_STAT | SEEK_STAT;
> +            ide_set_irq(s);
> +            break;
>              /* ATAPI commands */
>          case WIN_PIDENTIFY:
>              if (s->is_cdrom) {
> 
> 
>       
> 
> 
> 

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net