From: Gleb Natapov <gleb@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [5860] Cleanup {alloc|get}_cluster_offset() (Gleb Natapov)
Date: Thu, 11 Dec 2008 17:28:31 +0200 [thread overview]
Message-ID: <20081211152831.GN5555@redhat.com> (raw)
In-Reply-To: <49412EB4.7000308@suse.de>
On Thu, Dec 11, 2008 at 04:16:04PM +0100, Alexander Graf wrote:
> Gleb Natapov wrote:
> > On Wed, Dec 10, 2008 at 08:38:19AM -0600, Anthony Liguori wrote:
> >
> >> Hi Gleb,
> >>
> >> Anthony Liguori wrote:
> >>
> >>> Revision: 5860
> >>> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5860
> >>> Author: aliguori
> >>> Date: 2008-12-02 20:11:27 +0000 (Tue, 02 Dec 2008)
> >>>
> >>>
> >> According to https://bugzilla.novell.com/show_bug.cgi?id=457957, this
> >> changeset breaks compressed qcow2 on write and savevm.
> >>
> >> Can you please look into this?
> >>
> >>
> > Alexander, can you try the patch below?
> >
>
> The patch seems to work just fine. Please also take a look at Kevin's
> and see which one fits best. Since I'm not really into qcow2 code, I
> can't tell which one is the more accurate one.
>
> Thanks a lot for looking so quickly into this!
>
I considered initially something like Kevin solution. I think mine
fix is better for code readability reasons.
--
Gleb.
next prev parent reply other threads:[~2008-12-11 15:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 20:11 [Qemu-devel] [5860] Cleanup {alloc|get}_cluster_offset() (Gleb Natapov) Anthony Liguori
2008-12-10 14:38 ` Anthony Liguori
2008-12-10 14:47 ` Gleb Natapov
2008-12-11 11:00 ` Gleb Natapov
2008-12-11 13:21 ` Alexander Graf
2008-12-11 13:58 ` Gleb Natapov
2008-12-11 15:16 ` Alexander Graf
2008-12-11 15:28 ` Gleb Natapov [this message]
2008-12-11 17:32 ` Kevin Wolf
2008-12-11 17:42 ` Gleb Natapov
2008-12-17 13:06 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081211152831.GN5555@redhat.com \
--to=gleb@redhat.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).