From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LAnS6-00031D-QI
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 10:27:46 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LAnS6-00030z-Bm
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 10:27:46 -0500
Received: from [199.232.76.173] (port=47466 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LAnS6-00030s-0f
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 10:27:46 -0500
Received: from mx2.redhat.com ([66.187.237.31]:42470)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1LAnS5-0001K5-Jo
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 10:27:45 -0500
Date: Thu, 11 Dec 2008 17:28:31 +0200
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [5860] Cleanup {alloc|get}_cluster_offset() (Gleb
	Natapov)
Message-ID: <20081211152831.GN5555@redhat.com>
References: <E1L7bah-00055e-I4@cvs.savannah.gnu.org>
	<493FD45B.5010500@codemonkey.ws>
	<20081211110056.GJ5555@redhat.com> <49412EB4.7000308@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49412EB4.7000308@suse.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org

On Thu, Dec 11, 2008 at 04:16:04PM +0100, Alexander Graf wrote:
> Gleb Natapov wrote:
> > On Wed, Dec 10, 2008 at 08:38:19AM -0600, Anthony Liguori wrote:
> >   
> >> Hi Gleb,
> >>
> >> Anthony Liguori wrote:
> >>     
> >>> Revision: 5860
> >>>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5860
> >>> Author:   aliguori
> >>> Date:     2008-12-02 20:11:27 +0000 (Tue, 02 Dec 2008)
> >>>   
> >>>       
> >> According to https://bugzilla.novell.com/show_bug.cgi?id=457957, this  
> >> changeset breaks compressed qcow2 on write and savevm.
> >>
> >> Can you please look into this?
> >>
> >>     
> > Alexander, can you try the patch below?
> >   
> 
> The patch seems to work just fine. Please also take a look at Kevin's
> and see which one fits best. Since I'm not really into qcow2 code, I
> can't tell which one  is the more accurate one.
> 
> Thanks a lot for looking so quickly into this!
> 
I considered initially something like Kevin solution. I think mine
fix is better for code readability reasons.

--
			Gleb.