From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LApXO-00032i-IM
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 12:41:22 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LApXM-00031j-Vw
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 12:41:22 -0500
Received: from [199.232.76.173] (port=59295 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LApXM-00031e-S3
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 12:41:20 -0500
Received: from mx2.redhat.com ([66.187.237.31]:54751)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1LApXM-0005j5-As
	for qemu-devel@nongnu.org; Thu, 11 Dec 2008 12:41:20 -0500
Date: Thu, 11 Dec 2008 19:42:04 +0200
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [5860] Cleanup {alloc|get}_cluster_offset() (Gleb
	Natapov)
Message-ID: <20081211174204.GA26503@redhat.com>
References: <E1L7bah-00055e-I4@cvs.savannah.gnu.org>
	<493FD45B.5010500@codemonkey.ws> <20081211110056.GJ5555@redhat.com>
	<20081211183258.fqitybgdw8gwgocs@imap.suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081211183258.fqitybgdw8gwgocs@imap.suse.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@suse.de>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On Thu, Dec 11, 2008 at 06:32:58PM +0100, Kevin Wolf wrote:
> Am Do 11 Dez 2008 12:00:56 CET schrieb Gleb Natapov <gleb@redhat.com>:
>
>> On Wed, Dec 10, 2008 at 08:38:19AM -0600, Anthony Liguori wrote:
>>> Hi Gleb,
>>>
>>> Anthony Liguori wrote:
>>>> Revision: 5860
>>>>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5860
>>>> Author:   aliguori
>>>> Date:     2008-12-02 20:11:27 +0000 (Tue, 02 Dec 2008)
>>>>
>>>
>>> According to https://bugzilla.novell.com/show_bug.cgi?id=457957, this
>>> changeset breaks compressed qcow2 on write and savevm.
>>>
>>> Can you please look into this?
>>>
>> Alexander, can you try the patch below?
>
> Hm, no signed-off line yet. Anyway:
>
Here it is ;)

Signed-off-by: Gleb Natapov <gleb@redhat.com>

> Acked-by: Kevin Wolf <kwolf@suse.de>
>
>>
>>
>> diff --git a/block-qcow2.c b/block-qcow2.c
>> index b3b5f8f..d8ac647 100644
>> --- a/block-qcow2.c
>> +++ b/block-qcow2.c
>> @@ -620,6 +620,9 @@ static int count_contiguous_clusters(uint64_t   
>> nb_clusters, int cluster_size,
>>      int i;
>>      uint64_t offset = be64_to_cpu(l2_table[0]) & ~mask;
>>
>> +    if (!offset)
>> +        return 0;
>> +
>>      for (i = 0; i < nb_clusters; i++)
>>          if (offset + i * cluster_size != (be64_to_cpu(l2_table[i]) & ~mask))
>>              break;
>> @@ -981,6 +984,12 @@ static uint64_t   
>> alloc_cluster_offset(BlockDriverState *bs,
>>      /* how many available clusters ? */
>>
>>      while (i < nb_clusters) {
>> +        i += count_contiguous_clusters(nb_clusters - i, s->cluster_size,
>> +                &l2_table[l2_index + i], 0);
>> +
>> +        if(be64_to_cpu(l2_table[l2_index + i]))
>> +            break;
>> +
>>          i += count_contiguous_free_clusters(nb_clusters - i,
>>                  &l2_table[l2_index + i]);
>>
>> @@ -989,12 +998,6 @@ static uint64_t   
>> alloc_cluster_offset(BlockDriverState *bs,
>>          if ((cluster_offset & QCOW_OFLAG_COPIED) ||
>>                  (cluster_offset & QCOW_OFLAG_COMPRESSED))
>>              break;
>> -
>> -        i += count_contiguous_clusters(nb_clusters - i, s->cluster_size,
>> -                &l2_table[l2_index + i], 0);
>> -
>> -        if(be64_to_cpu(l2_table[l2_index + i]))
>> -            break;
>>      }
>>      nb_clusters = i;
>>
>> --
>> 			Gleb.
>>
>>
>>
>

--
			Gleb.