From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LAuFv-0001oP-G1 for qemu-devel@nongnu.org; Thu, 11 Dec 2008 17:43:39 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LAuFu-0001ns-LU for qemu-devel@nongnu.org; Thu, 11 Dec 2008 17:43:38 -0500 Received: from [199.232.76.173] (port=57833 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LAuFu-0001nm-Fj for qemu-devel@nongnu.org; Thu, 11 Dec 2008 17:43:38 -0500 Received: from hall.aurel32.net ([88.191.82.174]:57197) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LAuFu-0005C3-4U for qemu-devel@nongnu.org; Thu, 11 Dec 2008 17:43:38 -0500 Date: Thu, 11 Dec 2008 23:43:30 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] (no subject) Message-ID: <20081211224330.GA9083@hall.aurel32.net> References: <1229033553-26097-1-git-send-email-hollisb@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1229033553-26097-1-git-send-email-hollisb@us.ibm.com> Sender: Aurelien Jarno Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Hollis Blanchard On Thu, Dec 11, 2008 at 04:12:33PM -0600, Hollis Blanchard wrote: > I'm not familiar with this device, but I'm fairly certain the writel handler is > not supposed to recurse. > > Signed-off-by: Hollis Blanchard Thanks, applied. > diff --git a/hw/ppc405_boards.c b/hw/ppc405_boards.c > index 4144dae..1d8b6ab 100644 > --- a/hw/ppc405_boards.c > +++ b/hw/ppc405_boards.c > @@ -129,9 +129,9 @@ static uint32_t ref405ep_fpga_readl (void *opaque, target_phys_addr_t addr) > static void ref405ep_fpga_writel (void *opaque, > target_phys_addr_t addr, uint32_t value) > { > - ref405ep_fpga_writel(opaque, addr, (value >> 24) & 0xFF); > - ref405ep_fpga_writel(opaque, addr + 1, (value >> 16) & 0xFF); > - ref405ep_fpga_writel(opaque, addr + 2, (value >> 8) & 0xFF); > + ref405ep_fpga_writeb(opaque, addr, (value >> 24) & 0xFF); > + ref405ep_fpga_writeb(opaque, addr + 1, (value >> 16) & 0xFF); > + ref405ep_fpga_writeb(opaque, addr + 2, (value >> 8) & 0xFF); > ref405ep_fpga_writeb(opaque, addr + 3, value & 0xFF); > } > > > > -- .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 : :' : Debian developer | Electrical Engineer `. `' aurel32@debian.org | aurelien@aurel32.net `- people.debian.org/~aurel32 | www.aurel32.net