From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBBIh-0003XY-Ju for qemu-devel@nongnu.org; Fri, 12 Dec 2008 11:55:39 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBBIf-0003VD-Ms for qemu-devel@nongnu.org; Fri, 12 Dec 2008 11:55:39 -0500 Received: from [199.232.76.173] (port=51830 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBBIf-0003Ul-GK for qemu-devel@nongnu.org; Fri, 12 Dec 2008 11:55:37 -0500 Received: from mx2.redhat.com ([66.187.237.31]:49851) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LBBId-0007En-Ma for qemu-devel@nongnu.org; Fri, 12 Dec 2008 11:55:37 -0500 Date: Fri, 12 Dec 2008 14:54:26 -0200 From: Eduardo Habkost Subject: Re: [Qemu-devel] [PATCH 00/31] Logging code cleanup, take 2 Message-ID: <20081212165425.GC5157@blackpad> References: <1229094550-2022-1-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On Fri, Dec 12, 2008 at 06:25:44PM +0200, Blue Swirl wrote: > On 12/12/08, Eduardo Habkost wrote: > > This is a new take of the patches for cleaning up qemu logging/debugging > > code. The series grow a little, as I've macrofied more #ifdefs on other > > files. I've also changed the macros to use 'foo(bar, ## __VA_ARGS__)' > > instead of 'foo(bar, __VA_ARGS__)', as suggested by Anthony. > > Do you plan to convert Sparc too? My initial goal is to improve qemu logging so that we can easily change the way messages are logged (e.g. add timestamps to the log messages, or use other logging methods). This debugging code cleanup was just one step for reaching this goal. Most of the debugging #ifdefs on target-sparc are using printf() or fprintf(stderr), and the few 'logfile' occurrences are not easily converted to a single macro, so I didn't change it (yet). In addition to logging improvements, the debugging code can be unified. When that happens, I am sure sparc will be changed. -- Eduardo