From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LBDD1-0001Le-FV
	for qemu-devel@nongnu.org; Fri, 12 Dec 2008 13:57:55 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LBDCz-0001JT-Vs
	for qemu-devel@nongnu.org; Fri, 12 Dec 2008 13:57:55 -0500
Received: from [199.232.76.173] (port=60613 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LBDCz-0001J7-Lm
	for qemu-devel@nongnu.org; Fri, 12 Dec 2008 13:57:53 -0500
Received: from mtaout03-winn.ispmail.ntl.com ([81.103.221.49]:62232)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <sdbrady@ntlworld.com>) id 1LBDCz-0006Bz-0q
	for qemu-devel@nongnu.org; Fri, 12 Dec 2008 13:57:53 -0500
Received: from aamtaout02-winn.ispmail.ntl.com ([81.103.221.35])
	by mtaout03-winn.ispmail.ntl.com
	(InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id
	<20081212185748.PEFJ1691.mtaout03-winn.ispmail.ntl.com@aamtaout02-winn.ispmail.ntl.com>
	for <qemu-devel@nongnu.org>; Fri, 12 Dec 2008 18:57:48 +0000
Received: from miranda.arrow ([213.107.23.205])
	by aamtaout02-winn.ispmail.ntl.com
	(InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id
	<20081212185748.WILD21638.aamtaout02-winn.ispmail.ntl.com@miranda.arrow>
	for <qemu-devel@nongnu.org>; Fri, 12 Dec 2008 18:57:48 +0000
Received: from sdb by miranda.arrow with local (Exim 4.63)
	(envelope-from <sdbrady@ntlworld.com>) id 1LBDEV-0002Iz-0n
	for qemu-devel@nongnu.org; Fri, 12 Dec 2008 18:59:27 +0000
Date: Fri, 12 Dec 2008 18:59:26 +0000
From: Stuart Brady <sdbrady@ntlworld.com>
Subject: Re: [Qemu-devel] [PATCH 16/31] target-cris/translate.c: LOG_DIS macro
Message-ID: <20081212185926.GA8846@miranda.arrow>
References: <1229094550-2022-1-git-send-email-ehabkost@redhat.com>
	<1229094550-2022-17-git-send-email-ehabkost@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1229094550-2022-17-git-send-email-ehabkost@redhat.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Fri, Dec 12, 2008 at 01:08:55PM -0200, Eduardo Habkost wrote:
> Instead of using DIS(fprintf(logfile, fmt)) everywhere, create and use
> a LOG_DIS(fmt) macro. This will make changing the logging code easier
> in the future.

Hi,

Might LOG_DISAS provide better consistency with other targets?

Cheers,
-- 
Stuart Brady