From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LBX5w-0007M9-ET
	for qemu-devel@nongnu.org; Sat, 13 Dec 2008 11:11:56 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LBX5u-0007Lg-GF
	for qemu-devel@nongnu.org; Sat, 13 Dec 2008 11:11:55 -0500
Received: from [199.232.76.173] (port=47749 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LBX5u-0007Ld-Cl
	for qemu-devel@nongnu.org; Sat, 13 Dec 2008 11:11:54 -0500
Received: from mtaout02-winn.ispmail.ntl.com ([81.103.221.48]:35249)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <sdbrady@ntlworld.com>) id 1LBX5u-0000oG-15
	for qemu-devel@nongnu.org; Sat, 13 Dec 2008 11:11:54 -0500
Received: from aamtaout02-winn.ispmail.ntl.com ([81.103.221.35])
	by mtaout02-winn.ispmail.ntl.com
	(InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id
	<20081213161153.AIY1717.mtaout02-winn.ispmail.ntl.com@aamtaout02-winn.ispmail.ntl.com>
	for <qemu-devel@nongnu.org>; Sat, 13 Dec 2008 16:11:53 +0000
Received: from miranda.arrow ([213.107.23.205])
	by aamtaout02-winn.ispmail.ntl.com
	(InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id
	<20081213161152.GSBD21638.aamtaout02-winn.ispmail.ntl.com@miranda.arrow>
	for <qemu-devel@nongnu.org>; Sat, 13 Dec 2008 16:11:52 +0000
Received: from sdb by miranda.arrow with local (Exim 4.63)
	(envelope-from <sdbrady@ntlworld.com>) id 1LBX7Z-0002ze-7d
	for qemu-devel@nongnu.org; Sat, 13 Dec 2008 16:13:37 +0000
Date: Sat, 13 Dec 2008 16:13:37 +0000
From: Stuart Brady <sdbrady@ntlworld.com>
Subject: Re: [Qemu-devel] [6009] Fix smsw for x86_64 guest and bigendian host
	case
Message-ID: <20081213161337.GA11499@miranda.arrow>
References: <E1LBWlu-0006IP-Qd@cvs.savannah.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1LBWlu-0006IP-Qd@cvs.savannah.gnu.org>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sat, Dec 13, 2008 at 03:51:14PM +0000, malc wrote:
> +#if defined TARGET_X86_64 && defined WORDS_BIGENDIAN
> +            tcg_gen_ld32u_tl(cpu_T[0], cpu_env, offsetof(CPUX86State,cr[0]) + 4);
> +#else
>              tcg_gen_ld32u_tl(cpu_T[0], cpu_env, offsetof(CPUX86State,cr[0]));
> +#endif

Hmm -- shouldn't REG_L_OFFSET be added instead of using #ifdefs?
-- 
Stuart Brady