From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBuWb-0006c0-QI for qemu-devel@nongnu.org; Sun, 14 Dec 2008 12:13:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBuWa-0006bW-QB for qemu-devel@nongnu.org; Sun, 14 Dec 2008 12:13:01 -0500 Received: from [199.232.76.173] (port=49452 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBuWa-0006bQ-Kt for qemu-devel@nongnu.org; Sun, 14 Dec 2008 12:13:00 -0500 Received: from bsdimp.com ([199.45.160.85]:63122 helo=harmony.bsdimp.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LBuWa-0005Vf-6B for qemu-devel@nongnu.org; Sun, 14 Dec 2008 12:13:00 -0500 Date: Sun, 14 Dec 2008 09:10:43 -0700 (MST) Message-Id: <20081214.091043.-399282895.imp@bsdimp.com> Subject: Re: [Qemu-devel] [6023] Use a hex value instead of possibly ambiguous 8 bit character From: "M. Warner Losh" In-Reply-To: <20081214224559.c54b844a.mle+tools@mega-nerd.com> References: <20081214224559.c54b844a.mle+tools@mega-nerd.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, mle+tools@mega-nerd.com In message: <20081214224559.c54b844a.mle+tools@mega-nerd.com> Erik de Castro Lopo writes: : Johannes Schindelin wrote: : : > I vote against using isprint(c). The code is simple as it is, otherwise : > you'd have to look up what isprint() does, _and_ rely on isprint() being : > present. : > : > I know, there are many people on this list who are all too happy to rely : > on new-fangled C99 stuff or lock themselves (and others) in with GCCisms. : > Peronally, though, I find it utterly stupid to do that unless you really : > have to. : : isprint is part of C89 and any compiler less than 20 years old should : support it. isprint() also was in many K&R compilers, but that was system dependent. The VAX I used in college in 1985 had it, as did the 'C' compiler for my DEC Rainbow and the TOPS-20 C compiler written at my university... Warner