* [Qemu-devel] [PATCH] Use float_relation_* constants
@ 2008-12-14 1:31 Nathan Froyd
2008-12-14 11:12 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Froyd @ 2008-12-14 1:31 UTC (permalink / raw)
To: qemu-devel
(Apologies if this patch comes through multiple times; I've tried twice
already and haven't seen it come through on my end or in the list
archives.)
Use float_relation_* constants rather than magic numbers in
softfloat-native comparison routines.
Signed-off-by: Nathan Froyd <froydnj@codesourcery.com>
---
fpu/softfloat-native.c | 48 ++++++++++++++++++++++++------------------------
1 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/fpu/softfloat-native.c b/fpu/softfloat-native.c
index 0b24bab..cd88113 100644
--- a/fpu/softfloat-native.c
+++ b/fpu/softfloat-native.c
@@ -220,25 +220,25 @@ float32 float32_sqrt( float32 a STATUS_PARAM)
int float32_compare( float32 a, float32 b STATUS_PARAM )
{
if (a < b) {
- return -1;
+ return float_relation_less;
} else if (a == b) {
- return 0;
+ return float_relation_equal;
} else if (a > b) {
- return 1;
+ return float_relation_greater;
} else {
- return 2;
+ return float_relation_unordered;
}
}
int float32_compare_quiet( float32 a, float32 b STATUS_PARAM )
{
if (isless(a, b)) {
- return -1;
+ return float_relation_less;
} else if (a == b) {
- return 0;
+ return float_relation_equal;
} else if (isgreater(a, b)) {
- return 1;
+ return float_relation_greater;
} else {
- return 2;
+ return float_relation_unordered;
}
}
int float32_is_signaling_nan( float32 a1)
@@ -391,25 +391,25 @@ float64 float64_sqrt( float64 a STATUS_PARAM)
int float64_compare( float64 a, float64 b STATUS_PARAM )
{
if (a < b) {
- return -1;
+ return float_relation_less;
} else if (a == b) {
- return 0;
+ return float_relation_equal;
} else if (a > b) {
- return 1;
+ return float_relation_greater;
} else {
- return 2;
+ return float_relation_unordered;
}
}
int float64_compare_quiet( float64 a, float64 b STATUS_PARAM )
{
if (isless(a, b)) {
- return -1;
+ return float_relation_less;
} else if (a == b) {
- return 0;
+ return float_relation_equal;
} else if (isgreater(a, b)) {
- return 1;
+ return float_relation_greater;
} else {
- return 2;
+ return float_relation_unordered;
}
}
int float64_is_signaling_nan( float64 a1)
@@ -483,25 +483,25 @@ floatx80 floatx80_sqrt( floatx80 a STATUS_PARAM)
int floatx80_compare( floatx80 a, floatx80 b STATUS_PARAM )
{
if (a < b) {
- return -1;
+ return float_relation_less;
} else if (a == b) {
- return 0;
+ return float_relation_equal;
} else if (a > b) {
- return 1;
+ return float_relation_greater;
} else {
- return 2;
+ return float_relation_unordered;
}
}
int floatx80_compare_quiet( floatx80 a, floatx80 b STATUS_PARAM )
{
if (isless(a, b)) {
- return -1;
+ return float_relation_less;
} else if (a == b) {
- return 0;
+ return float_relation_equal;
} else if (isgreater(a, b)) {
- return 1;
+ return float_relation_greater;
} else {
- return 2;
+ return float_relation_unordered;
}
}
int floatx80_is_signaling_nan( floatx80 a1)
--
1.6.0.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] Use float_relation_* constants
2008-12-14 1:31 [Qemu-devel] [PATCH] Use float_relation_* constants Nathan Froyd
@ 2008-12-14 11:12 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2008-12-14 11:12 UTC (permalink / raw)
To: qemu-devel
On Sat, Dec 13, 2008 at 05:31:26PM -0800, Nathan Froyd wrote:
> (Apologies if this patch comes through multiple times; I've tried twice
> already and haven't seen it come through on my end or in the list
> archives.)
>
> Use float_relation_* constants rather than magic numbers in
> softfloat-native comparison routines.
>
> Signed-off-by: Nathan Froyd <froydnj@codesourcery.com>
Thanks, applied.
> ---
> fpu/softfloat-native.c | 48 ++++++++++++++++++++++++------------------------
> 1 files changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/fpu/softfloat-native.c b/fpu/softfloat-native.c
> index 0b24bab..cd88113 100644
> --- a/fpu/softfloat-native.c
> +++ b/fpu/softfloat-native.c
> @@ -220,25 +220,25 @@ float32 float32_sqrt( float32 a STATUS_PARAM)
> int float32_compare( float32 a, float32 b STATUS_PARAM )
> {
> if (a < b) {
> - return -1;
> + return float_relation_less;
> } else if (a == b) {
> - return 0;
> + return float_relation_equal;
> } else if (a > b) {
> - return 1;
> + return float_relation_greater;
> } else {
> - return 2;
> + return float_relation_unordered;
> }
> }
> int float32_compare_quiet( float32 a, float32 b STATUS_PARAM )
> {
> if (isless(a, b)) {
> - return -1;
> + return float_relation_less;
> } else if (a == b) {
> - return 0;
> + return float_relation_equal;
> } else if (isgreater(a, b)) {
> - return 1;
> + return float_relation_greater;
> } else {
> - return 2;
> + return float_relation_unordered;
> }
> }
> int float32_is_signaling_nan( float32 a1)
> @@ -391,25 +391,25 @@ float64 float64_sqrt( float64 a STATUS_PARAM)
> int float64_compare( float64 a, float64 b STATUS_PARAM )
> {
> if (a < b) {
> - return -1;
> + return float_relation_less;
> } else if (a == b) {
> - return 0;
> + return float_relation_equal;
> } else if (a > b) {
> - return 1;
> + return float_relation_greater;
> } else {
> - return 2;
> + return float_relation_unordered;
> }
> }
> int float64_compare_quiet( float64 a, float64 b STATUS_PARAM )
> {
> if (isless(a, b)) {
> - return -1;
> + return float_relation_less;
> } else if (a == b) {
> - return 0;
> + return float_relation_equal;
> } else if (isgreater(a, b)) {
> - return 1;
> + return float_relation_greater;
> } else {
> - return 2;
> + return float_relation_unordered;
> }
> }
> int float64_is_signaling_nan( float64 a1)
> @@ -483,25 +483,25 @@ floatx80 floatx80_sqrt( floatx80 a STATUS_PARAM)
> int floatx80_compare( floatx80 a, floatx80 b STATUS_PARAM )
> {
> if (a < b) {
> - return -1;
> + return float_relation_less;
> } else if (a == b) {
> - return 0;
> + return float_relation_equal;
> } else if (a > b) {
> - return 1;
> + return float_relation_greater;
> } else {
> - return 2;
> + return float_relation_unordered;
> }
> }
> int floatx80_compare_quiet( floatx80 a, floatx80 b STATUS_PARAM )
> {
> if (isless(a, b)) {
> - return -1;
> + return float_relation_less;
> } else if (a == b) {
> - return 0;
> + return float_relation_equal;
> } else if (isgreater(a, b)) {
> - return 1;
> + return float_relation_greater;
> } else {
> - return 2;
> + return float_relation_unordered;
> }
> }
> int floatx80_is_signaling_nan( floatx80 a1)
> --
> 1.6.0.5
>
>
>
>
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-14 11:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-14 1:31 [Qemu-devel] [PATCH] Use float_relation_* constants Nathan Froyd
2008-12-14 11:12 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).