From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBuGV-000237-Jp for qemu-devel@nongnu.org; Sun, 14 Dec 2008 11:56:23 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBuGT-00022X-NA for qemu-devel@nongnu.org; Sun, 14 Dec 2008 11:56:22 -0500 Received: from [199.232.76.173] (port=57349 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBuGT-00022Q-IW for qemu-devel@nongnu.org; Sun, 14 Dec 2008 11:56:21 -0500 Received: from hall.aurel32.net ([88.191.82.174]:39719) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LBuGT-00047b-31 for qemu-devel@nongnu.org; Sun, 14 Dec 2008 11:56:21 -0500 Received: from aurel32 by hall.aurel32.net with local (Exim 4.63) (envelope-from ) id 1LBuGO-0004JH-Pv for qemu-devel@nongnu.org; Sun, 14 Dec 2008 17:56:16 +0100 Date: Sun, 14 Dec 2008 17:56:16 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [6028] target-ppc: use -Werror to make sure no new warning is added Message-ID: <20081214165616.GH22069@hall.aurel32.net> References: <20081214150928.GA13792@miranda.arrow> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20081214150928.GA13792@miranda.arrow> Sender: Aurelien Jarno Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sun, Dec 14, 2008 at 03:09:28PM +0000, Stuart Brady wrote: > On Sun, Dec 14, 2008 at 11:12:28AM +0000, Aurelien Jarno wrote: > > Log Message: > > ----------- > > target-ppc: use -Werror to make sure no new warning is added > > make -C ppc-softmmu all > make[1]: Entering directory `.../qemu/ppc-softmmu' > gcc ... .../qemu/vl.c > cc1: warnings being treated as errors > .../qemu/vl.c: In function 'host_alarm_handler': > .../qemu/vl.c:1352: error: ignoring return value of 'write', declared > with attribute warn_unused_result > .../qemu/vl.c: In function 'main': > .../qemu/vl.c:5202: error: ignoring return value of 'write', declared > with attribute warn_unused_result > .../qemu/vl.c:5515: error: ignoring return value of 'chdir', declared > with attribute warn_unused_result > make[1]: *** [vl.o] Error 1 > make[1]: Leaving directory `.../qemu/ppc-softmmu' > make: *** [subdir-ppc-softmmu] Error 2 Which compiler are you using? I don't have those warnings. > Also this one, which is a bit more trivial: > > .../qemu/tcg/tcg.c: In function 'tcg_dump_ops': > .../qemu/tcg/tcg.c:889: warning: format not a string literal and no > format arguments > > Index: tcg/tcg.c > =================================================================== > --- tcg/tcg.c (revision 6028) > +++ tcg/tcg.c (working copy) > @@ -886,7 +886,7 @@ > val = args[1]; > th = tcg_find_helper(s, val); > if (th) { > - fprintf(outfile, th->name); > + fprintf(outfile, "%s", th->name); > } else { > if (c == INDEX_op_movi_i32) > fprintf(outfile, "0x%x", (uint32_t)val); > > Perhaps these should be fixed, but -Werror is a bit of a pain, as you > can't choose which warnings are critical, and different warnings will > be generated with different versions of gcc, different optimisation > levels and different header files. > > Additional warnings get added, and some warnings might become less noisy > in the future... perhaps this one might just go away, given time: > > .../qemu/target-cris/translate.c: In function 'dec_movem_mr': > .../qemu/target-cris/translate.c:2727: warning: 'tmp32' may be used > uninitialized in this function > > Cheers, > -- > Stuart Brady > > > -- .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 : :' : Debian developer | Electrical Engineer `. `' aurel32@debian.org | aurelien@aurel32.net `- people.debian.org/~aurel32 | www.aurel32.net