From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBuZq-0000Oc-00 for qemu-devel@nongnu.org; Sun, 14 Dec 2008 12:16:22 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBuZo-0000M0-5T for qemu-devel@nongnu.org; Sun, 14 Dec 2008 12:16:21 -0500 Received: from [199.232.76.173] (port=49486 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBuZn-0000Lm-QR for qemu-devel@nongnu.org; Sun, 14 Dec 2008 12:16:19 -0500 Received: from mail2.shareable.org ([80.68.89.115]:48731) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LBuZn-0005iv-J7 for qemu-devel@nongnu.org; Sun, 14 Dec 2008 12:16:19 -0500 Date: Sun, 14 Dec 2008 17:16:11 +0000 From: Jamie Lokier Subject: Re: [Qemu-devel] [6023] Use a hex value instead of possibly ambiguous 8 bit character Message-ID: <20081214171611.GB28984@shareable.org> References: <20081214224559.c54b844a.mle+tools@mega-nerd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Erik de Castro Lopo Johannes Schindelin wrote: > > isprint is part of C89 and any compiler less than 20 years old should > > support it. > > Okay, so it is C89. So what does it do exactly? Yes, exactly you have to > look it up. Nice job. > > Whatever, > Dscho > > P.S.: oh, so now the umlauts are not even printed when you are on an > ISO-8859-1 console? Nice job, again. isprint should return true for umlaut characters on an ISO-8859-1 console, provided the locale ($LANG, $LC_CTYPE) matches the console. The question is whether you want QEMU's debugging output to depend on the current locale, or be the same for everyone. If the former, isprint is quite appropriate. If the latter, restricting to ASCII is appropriate. -- Jamie