From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBpQN-000898-1F for qemu-devel@nongnu.org; Sun, 14 Dec 2008 06:46:15 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBpQI-00088Y-Sn for qemu-devel@nongnu.org; Sun, 14 Dec 2008 06:46:14 -0500 Received: from [199.232.76.173] (port=60326 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBpQH-00088J-0a for qemu-devel@nongnu.org; Sun, 14 Dec 2008 06:46:09 -0500 Received: from outbound.icp-qv1-irony-out3.iinet.net.au ([203.59.1.148]:8660) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LBpQG-0006eE-AJ for qemu-devel@nongnu.org; Sun, 14 Dec 2008 06:46:08 -0500 Received: from hendrix (hendrix [192.168.200.99]) by hendrix.mega-nerd.net (Postfix) with SMTP id 8B955AB185 for ; Sun, 14 Dec 2008 22:45:59 +1100 (EST) Date: Sun, 14 Dec 2008 22:45:59 +1100 From: Erik de Castro Lopo Subject: Re: [Qemu-devel] [6023] Use a hex value instead of possibly ambiguous 8 bit character Message-Id: <20081214224559.c54b844a.mle+tools@mega-nerd.com> In-Reply-To: References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Johannes Schindelin wrote: > I vote against using isprint(c). The code is simple as it is, otherwise > you'd have to look up what isprint() does, _and_ rely on isprint() being > present. > > I know, there are many people on this list who are all too happy to rely > on new-fangled C99 stuff or lock themselves (and others) in with GCCisms. > Peronally, though, I find it utterly stupid to do that unless you really > have to. isprint is part of C89 and any compiler less than 20 years old should support it. Erik -- ----------------------------------------------------------------- Erik de Castro Lopo ----------------------------------------------------------------- Complex problems have simple easy to understand wrong answers.