qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Nathan Froyd <froydnj@codesourcery.com>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 03/42] target-ppc: add gen_avr_ptr function.
Date: Mon, 15 Dec 2008 23:13:55 +0000	[thread overview]
Message-ID: <200812152313.56071.paul@codesourcery.com> (raw)
In-Reply-To: <20081215221643.GG8523@volta.aurel32.net>

> I am still pondering what is the better solution between passing a
> pointer to an avr register or the avr register number.
>
> Does someone has an opinion about that?

FWIW it was probably me recommended passing things by value.
It feels cleaner because with pointers it's pretty much impossible to TCG to 
tell what's going on.

I was also hoping that it would mean many of the helpers could be shared 
between AltiVec and SPE. On closer inspection it looks like there aren't 
really that many interesting opportunities for this.

On ARM NEON there are two different vector lengths, and registers overlap in 
interesting ways, so we need most of the splitting and iteration stuff 
anyway. AltiVec and SSE are more restricted instruction sets, so I guess 
there's probably less benefit.

Paul

  parent reply	other threads:[~2008-12-15 23:14 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-15  2:14 [Qemu-devel] [PATCH] target-ppc: add Altivec instructions, patch-bomb version Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 01/42] target-ppc: add Altivec logical operations Nathan Froyd
2008-12-15 22:11   ` Aurelien Jarno
2008-12-16 19:51     ` Nathan Froyd
2008-12-18 22:48       ` Aurelien Jarno
2008-12-15  2:14 ` [Qemu-devel] [PATCH 02/42] target-ppc: add helper macros for later patches Nathan Froyd
2008-12-15 22:15   ` Aurelien Jarno
2008-12-16 15:25   ` Aurelien Jarno
2008-12-15  2:14 ` [Qemu-devel] [PATCH 03/42] target-ppc: add gen_avr_ptr function Nathan Froyd
2008-12-15 22:16   ` Aurelien Jarno
2008-12-15 22:41     ` Aurelien Jarno
2008-12-15 23:13     ` Paul Brook [this message]
2008-12-18 22:51   ` Aurelien Jarno
2008-12-15  2:14 ` [Qemu-devel] [PATCH 04/42] target-ppc: add GEN_VXFORM macro for subsequent instructions Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 05/42] target-ppc: add v{add, sub}u{b, h, w}m instructions Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 06/42] target-ppc: add signed fields to ppc_avr_t Nathan Froyd
2008-12-15  7:04   ` Aurelien Jarno
2008-12-15  2:14 ` [Qemu-devel] [PATCH 07/42] target-ppc: add vavg{s, u}{b, h, w} instructions Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 08/42] target-ppc: add v{min, max}{s, " Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 09/42] target-ppc: add GEN_VXRFORM{, 1} macros for subsequent instructions Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 10/42] target-ppc: add vcmpequ{b, h, w} and vcmpgt{s, u}{b, h, w} instructions Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 11/42] target-ppc: add vscr access macros Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 12/42] target-ppc: add vmrg{l, h}{b, h, w} instructions Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 13/42] target-ppc: add vmul{e, o}{s, u}{b, h} instructions Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 14/42] target-ppc: add vsr{, a}{b, h, w} instructions Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 15/42] target-ppc: add vsl{b, " Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 16/42] target-ppc: add vs{l,r}o instructions Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 17/42] target-ppc: add v{add, sub}cuw instructions Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 18/42] target-ppc: add lvs{l,r} instructions Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 19/42] target-ppc: add m{f, t}vscr instructions Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 20/42] target-ppc: add v{add, sub}{s, u}{b, h, w}s instructions Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 21/42] target-ppc: add vrl{b, h, w} instructions Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 22/42] target-ppc: add vs{l,r} instructions Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 23/42] target-ppc: add vsldoi instruction Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 24/42] target-ppc: add GEN_VXFORM_SIMM macro for subsequent instructions Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 25/42] target-ppc: add vspltis{b, h, w} instructions Nathan Froyd
2008-12-15  2:14 ` [Qemu-devel] [PATCH 26/42] target-ppc: add GEN_VXFORM_UIMM macro for subsequent instructions Nathan Froyd
2008-12-15  2:15 ` [Qemu-devel] [PATCH 27/42] target-ppc: add vsplt{b, h, w} instructions Nathan Froyd
2008-12-15  2:15 ` [Qemu-devel] [PATCH 28/42] target-ppc: add GEN_VXFORM_NOA macro for subsequent instructions Nathan Froyd
2008-12-15  2:15 ` [Qemu-devel] [PATCH 29/42] target-ppc: add vupk{h, l}px instructions Nathan Froyd
2008-12-15  2:15 ` [Qemu-devel] [PATCH 30/42] target-ppc: add vupk{h, l}s{b, h} instructions Nathan Froyd
2008-12-15  2:15 ` [Qemu-devel] [PATCH 31/42] target-ppc: add GEN_VAFORM_PAIRED macro for subsequent instructions Nathan Froyd
2008-12-15  2:15 ` [Qemu-devel] [PATCH 32/42] target-ppc: add vmsum{u, m}bm instructions Nathan Froyd
2008-12-15  2:15 ` [Qemu-devel] [PATCH 33/42] target-ppc: add vsel and vperm instructions Nathan Froyd
2008-12-15  2:15 ` [Qemu-devel] [PATCH 34/42] target-ppc: add saturating arithmetic conversion functions for subsequent instructions Nathan Froyd
2008-12-15  2:15 ` [Qemu-devel] [PATCH 35/42] target-ppc: add vpks{h, w}{s, u}s, vpku{h, w}us, and vpku{h, w}um instructions Nathan Froyd
2008-12-15  2:15 ` [Qemu-devel] [PATCH 36/42] target-ppc: add vpkpx instruction Nathan Froyd
2008-12-15  2:15 ` [Qemu-devel] [PATCH 37/42] target-ppc: add vmh{, r}addshs instructions Nathan Froyd
2008-12-15  2:15 ` [Qemu-devel] [PATCH 38/42] target-ppc: add vmsumuh{m, s} instructions Nathan Froyd
2008-12-15  2:15 ` [Qemu-devel] [PATCH 39/42] target-ppc: add vmsumsh{m, " Nathan Froyd
2008-12-15  2:15 ` [Qemu-devel] [PATCH 40/42] target-ppc: add vmladduhm instruction Nathan Froyd
2008-12-15  2:15 ` [Qemu-devel] [PATCH 41/42] target-ppc: add {l, st}ve{b, h, w}x instructions Nathan Froyd
2008-12-15  2:15 ` [Qemu-devel] [PATCH 42/42] target-ppc: add vsumsws, vsum2sws, and vsum4{sbs, shs, ubs} instructions Nathan Froyd
2008-12-15  6:40 ` [Qemu-devel] [PATCH] target-ppc: add Altivec instructions, patch-bomb version Aurelien Jarno
2008-12-15  7:11   ` Laurent Desnogues
2008-12-15 17:38   ` Nathan Froyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200812152313.56071.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=aurelien@aurel32.net \
    --cc=froydnj@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).