From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LCgkG-0001kb-N4
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 15:42:20 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LCgkF-0001ie-2m
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 15:42:20 -0500
Received: from [199.232.76.173] (port=55826 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LCgkE-0001iS-V4
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 15:42:18 -0500
Received: from mail2.shareable.org ([80.68.89.115]:54061)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <jamie@shareable.org>) id 1LCgkE-0006gq-J3
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 15:42:18 -0500
Received: from jamie by mail2.shareable.org with local (Exim 4.63)
	(envelope-from <jamie@shareable.org>) id 1LCgkB-0004wX-RT
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 20:42:15 +0000
Date: Tue, 16 Dec 2008 20:42:15 +0000
From: Jamie Lokier <jamie@shareable.org>
Subject: Re: [Qemu-devel] [PATCH] Add rtl8139b
Message-ID: <20081216204215.GC15605@shareable.org>
References: <200812141850.mBEIoBtN019561@smtp11.dti.ne.jp>
	<20081216191957.GA15605@shareable.org>
	<b2fa41d60812161145p4d75277yc9c6805c7b48f34a@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b2fa41d60812161145p4d75277yc9c6805c7b48f34a@mail.gmail.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Igor Kovalenko wrote:
> On Tue, Dec 16, 2008 at 10:19 PM, Jamie Lokier <jamie@shareable.org> wrote:
> > takasi-y@ops.dti.ne.jp wrote:
> >> +                        " ne2k_pci pcnet rtl8139 rtl8139b e1000\n");
> >
> > On seeing this in qemu output, and with no documentation, it suggests
> > "rtl8139b" is a later device revision than "rtl8139", and preferable
> > to use for new VMs.
> >
> > Imho it would be better to write " rtl8139b rtl8139 " and of course
> > document that rtl8139b is an older device than rtl8139.
> >
> 
> -net nic,model=rtl8139[,quirks=8139cplus|8139b] default to 8139cplus

Nice!  I'd change to [,revision=8139cplus|8139b], as it's not a quirk.

-- Jamie