From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LCyHu-0007QS-NZ for qemu-devel@nongnu.org; Wed, 17 Dec 2008 10:26:14 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LCyHt-0007Os-8L for qemu-devel@nongnu.org; Wed, 17 Dec 2008 10:26:14 -0500 Received: from [199.232.76.173] (port=48107 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LCyHs-0007Og-Vv for qemu-devel@nongnu.org; Wed, 17 Dec 2008 10:26:13 -0500 Received: from mx1.redhat.com ([66.187.233.31]:35892) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LCyHs-0001Tk-JU for qemu-devel@nongnu.org; Wed, 17 Dec 2008 10:26:12 -0500 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id mBHFQ4G9014106 for ; Wed, 17 Dec 2008 10:26:04 -0500 Received: from file.fab.redhat.com (file.fab.redhat.com [10.33.63.6]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mBHFQ3Jn020925 for ; Wed, 17 Dec 2008 10:26:03 -0500 Received: from file.fab.redhat.com (localhost.localdomain [127.0.0.1]) by file.fab.redhat.com (8.13.1/8.13.1) with ESMTP id mBHFQ31C029024 for ; Wed, 17 Dec 2008 15:26:03 GMT Received: (from berrange@localhost) by file.fab.redhat.com (8.13.1/8.13.1/Submit) id mBHFQ3Gv029002 for qemu-devel@nongnu.org; Wed, 17 Dec 2008 15:26:03 GMT Date: Wed, 17 Dec 2008 15:26:03 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH 0/3] Add BIOS splash image support Message-ID: <20081217152603.GV13455@redhat.com> References: <1229440810-12394-1-git-send-email-Laurent.Vivier@bull.net> <49480F6D.2010302@codemonkey.ws> <20081217110319.GD13455@redhat.com> <200812171318.58650.paul@codesourcery.com> <49490282.3080800@siemens.com> <4949116F.6090604@redhat.com> <49491293.9070501@siemens.com> <49491519.4080907@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49491519.4080907@suse.de> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Wed, Dec 17, 2008 at 04:04:57PM +0100, Kevin Wolf wrote: > Jan Kiszka schrieb: > > Gerd Hoffmann wrote: > >> Jan Kiszka wrote: > >>> Yes, please. I hate this artificial delay, specifically as I have to do > >>> a lot of short boot tests where this contributes noticeably to their > >>> execution time. But, as usual, it didn't hurt enough to make me hack a > >>> patch yet. I'm willing to do this if we can agree on how it should be done. > >> Show the boot menu only on case no "-boot whatever" cmd line option is > >> present? > > > > I would say only when there is -bootmenu as Gleb suggested. I'm half > > done with this approach already. > > I like Gerd's approach better as it doesn't introduce yet another > command line parameter. It makes sense to me that you don't want a menu > if you specify -boot. Actually no it doesn't. The reason the original author wrote this boot menu patch was explicitly so that if you had used a '-boot d' arg, you could do a one-time override from the BIOS screen. One other alternative to added a brand new arg is to just allow an extra meta-character in -boot arg to indicate that it should prompt or not -boot d (use cdrom) vs -boot d+ (default cdrom, prompt to allow override) but perhaps that's a bit obtuse Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|