From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LIOfq-0003eb-Fx for qemu-devel@nongnu.org; Thu, 01 Jan 2009 09:37:22 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LIOfn-0003bE-SE for qemu-devel@nongnu.org; Thu, 01 Jan 2009 09:37:21 -0500 Received: from [199.232.76.173] (port=53570 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LIOfn-0003as-MJ for qemu-devel@nongnu.org; Thu, 01 Jan 2009 09:37:19 -0500 Received: from mtaout02-winn.ispmail.ntl.com ([81.103.221.48]:57561) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LIOfn-0007rf-7F for qemu-devel@nongnu.org; Thu, 01 Jan 2009 09:37:19 -0500 Received: from aamtaout04-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout02-winn.ispmail.ntl.com (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id <20090101143651.HOYN4080.mtaout02-winn.ispmail.ntl.com@aamtaout04-winn.ispmail.ntl.com> for ; Thu, 1 Jan 2009 14:36:51 +0000 Received: from miranda.arrow ([213.107.23.205]) by aamtaout04-winn.ispmail.ntl.com (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id <20090101143651.JRLP22934.aamtaout04-winn.ispmail.ntl.com@miranda.arrow> for ; Thu, 1 Jan 2009 14:36:51 +0000 Received: from sdb by miranda.arrow with local (Exim 4.63) (envelope-from ) id 1LIOfJ-0004lg-F9 for qemu-devel@nongnu.org; Thu, 01 Jan 2009 14:36:49 +0000 Date: Thu, 1 Jan 2009 14:36:49 +0000 From: Stuart Brady Subject: Re: [Qemu-devel] [PATCH] tcg_temp_local_new should take no parameter Message-ID: <20090101143649.GA18298@miranda.arrow> References: <761ea48b0901010519h798dac6at764a799ed630b81c@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <761ea48b0901010519h798dac6at764a799ed630b81c@mail.gmail.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Thu, Jan 01, 2009 at 02:19:10PM +0100, Laurent Desnogues wrote: > Index: target-ppc/translate.c > =================================================================== > --- target-ppc/translate.c (revision 6144) > +++ target-ppc/translate.c (working copy) > @@ -6350,7 +6350,7 @@ > TCGv_i32 t0 = tcg_temp_local_new_i32(); \ > TCGv_i32 t1 = tcg_temp_local_new_i32(); \ > TCGv_i32 t2 = tcg_temp_local_new_i32(); \ > - TCGv_i64 t3 = tcg_temp_local_new(TCG_TYPE_I64); \ > + TCGv_i64 t3 = tcg_temp_local_new(); \ > tcg_gen_trunc_i64_i32(t0, cpu_gpr[rA(ctx->opcode)]); \ > tcg_gen_trunc_i64_i32(t2, cpu_gpr[rB(ctx->opcode)]); \ > tcg_op(t0, t0, t2); \ Wouldn't tcg_temp_local_new_i64 be a little clearer, as t3 is later freed with tcg_temp_free_i64()? The SH4 emulation seems to use 'plain' TCGv mostly, expects it to be 32-bits, and doesn't use the _tl macros, which I suppose is reasonable for a 32-bit only target. Alpha, ARM and M68K do something similar (so I'll try to follow the style that they use) but CRIS uses _tl a lot, which seems peculiar... Cheers, -- Stuart Brady