[Qemu-devel] [PATCH] Fix documentation of qemu_ld/st ops

[Qemu-devel] [PATCH] Fix documentation of qemu_ld/st ops

[Stuart Brady]

This patch corrects the documentation of the qemu_ld and qemu_st ops.

The functions defined in tcg/tcg-op.h have no _i32 or _i64 suffix,
qemu_ld64 and qemu_st64 were missing from the list, and there are
no 'plain' qemu_ld/qemu_st ops.

Signed-off-by: Stuart Brady <stuart.brady@gmail.com>

Index: tcg/README
===================================================================
--- tcg/README	(revision 6146)
+++ tcg/README	(working copy)
@@ -334,22 +334,22 @@
 current TB was linked to this TB. Otherwise execute the next
 instructions.
 
-* qemu_ld_i32/i64 t0, t1, flags
-qemu_ld8u_i32/i64 t0, t1, flags
-qemu_ld8s_i32/i64 t0, t1, flags
-qemu_ld16u_i32/i64 t0, t1, flags
-qemu_ld16s_i32/i64 t0, t1, flags
-qemu_ld32u_i64 t0, t1, flags
-qemu_ld32s_i64 t0, t1, flags
+* qemu_ld8u t0, t1, flags
+qemu_ld8s t0, t1, flags
+qemu_ld16u t0, t1, flags
+qemu_ld16s t0, t1, flags
+qemu_ld32u t0, t1, flags
+qemu_ld32s t0, t1, flags
+qemu_ld64 t0, t1, flags
 
 Load data at the QEMU CPU address t1 into t0. t1 has the QEMU CPU
 address type. 'flags' contains the QEMU memory index (selects user or
 kernel access) for example.
 
-* qemu_st_i32/i64 t0, t1, flags
-qemu_st8_i32/i64 t0, t1, flags
-qemu_st16_i32/i64 t0, t1, flags
-qemu_st32_i64 t0, t1, flags
+* qemu_st8 t0, t1, flags
+qemu_st16 t0, t1, flags
+qemu_st32 t0, t1, flags
+qemu_st64 t0, t1, flags
 
 Store the data t0 at the QEMU CPU Address t1. t1 has the QEMU CPU
 address type. 'flags' contains the QEMU memory index (selects user or

Cheers,
-- 
Stuart Brady

Re: [Qemu-devel] [PATCH] Fix documentation of qemu_ld/st ops

[Aurelien Jarno]

On Thu, Jan 01, 2009 at 09:08:17PM +0000, Stuart Brady wrote:
> This patch corrects the documentation of the qemu_ld and qemu_st ops.
> 
> The functions defined in tcg/tcg-op.h have no _i32 or _i64 suffix,
> qemu_ld64 and qemu_st64 were missing from the list, and there are
> no 'plain' qemu_ld/qemu_st ops.
> 
> Signed-off-by: Stuart Brady <stuart.brady@gmail.com>

Thanks applied.

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net