[Qemu-devel] [PATCH] remove tcg_global_reg2_new_hack()

[Qemu-devel] [PATCH] remove tcg_global_reg2_new_hack()

[Stuart Brady]

This patch removes the unused tcg_global_reg2_new_hack() function, which
was added in r4438 to work around a register shortage problem regarding
dyngen.  The only ever user of this function was removed in r4577.

Signed-off-by: Stuart Brady <stuart.brady@gmail.com>

Index: tcg/tcg.c
===================================================================
--- tcg/tcg.c	(revision 6146)
+++ tcg/tcg.c	(working copy)
@@ -313,43 +313,6 @@
     return MAKE_TCGV_I64(idx);
 }
 
-#if TCG_TARGET_REG_BITS == 32
-/* temporary hack to avoid register shortage for tcg_qemu_st64() */
-TCGv_i64 tcg_global_reg2_new_hack(TCGType type, int reg1, int reg2,
-                                  const char *name)
-{
-    TCGContext *s = &tcg_ctx;
-    TCGTemp *ts;
-    int idx;
-    char buf[64];
-
-    if (type != TCG_TYPE_I64)
-        tcg_abort();
-    idx = s->nb_globals;
-    tcg_temp_alloc(s, s->nb_globals + 2);
-    ts = &s->temps[s->nb_globals];
-    ts->base_type = type;
-    ts->type = TCG_TYPE_I32;
-    ts->fixed_reg = 1;
-    ts->reg = reg1;
-    pstrcpy(buf, sizeof(buf), name);
-    pstrcat(buf, sizeof(buf), "_0");
-    ts->name = strdup(buf);
-
-    ts++;
-    ts->base_type = type;
-    ts->type = TCG_TYPE_I32;
-    ts->fixed_reg = 1;
-    ts->reg = reg2;
-    pstrcpy(buf, sizeof(buf), name);
-    pstrcat(buf, sizeof(buf), "_1");
-    ts->name = strdup(buf);
-
-    s->nb_globals += 2;
-    return MAKE_TCGV_I64(idx);
-}
-#endif
-
 static inline int tcg_global_mem_new_internal(TCGType type, int reg,
                                               tcg_target_long offset,
                                               const char *name)
Index: tcg/tcg.h
===================================================================
--- tcg/tcg.h	(revision 6146)
+++ tcg/tcg.h	(working copy)
@@ -319,8 +319,6 @@
 
 void tcg_set_frame(TCGContext *s, int reg,
                    tcg_target_long start, tcg_target_long size);
-TCGv_i64 tcg_global_reg2_new_hack(TCGType type, int reg1, int reg2,
-                                  const char *name);
 
 TCGv_i32 tcg_global_reg_new_i32(int reg, const char *name);
 TCGv_i32 tcg_global_mem_new_i32(int reg, tcg_target_long offset,

Cheers,
-- 
Stuart Brady

Re: [Qemu-devel] [PATCH] remove tcg_global_reg2_new_hack()

[Aurelien Jarno]

On Fri, Jan 02, 2009 at 11:09:53AM +0000, Stuart Brady wrote:
> This patch removes the unused tcg_global_reg2_new_hack() function, which
> was added in r4438 to work around a register shortage problem regarding
> dyngen.  The only ever user of this function was removed in r4577.
> 
> Signed-off-by: Stuart Brady <stuart.brady@gmail.com>

Thanks applied.

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net