From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LK967-0007UX-K3
	for qemu-devel@nongnu.org; Tue, 06 Jan 2009 05:23:43 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LK964-0007Tb-Hc
	for qemu-devel@nongnu.org; Tue, 06 Jan 2009 05:23:42 -0500
Received: from [199.232.76.173] (port=53254 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LK963-0007TA-U2
	for qemu-devel@nongnu.org; Tue, 06 Jan 2009 05:23:40 -0500
Received: from 2.mail-out.ovh.net ([91.121.26.226]:58312)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <plagnioj@jcrosoft.com>) id 1LK962-00007S-W6
	for qemu-devel@nongnu.org; Tue, 06 Jan 2009 05:23:39 -0500
Date: Tue, 6 Jan 2009 11:14:10 +0100
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Subject: Re: [Qemu-devel] [PATCH] [RFC] sh: SM501 usb host emulation
Message-ID: <20090106101410.GD29775@game.jcrosoft.org>
References: <49564399.7020006@juno.dti.ne.jp> <495EFD0D.8050002@juno.dti.ne.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <495EFD0D.8050002@juno.dti.ne.jp>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Shin-ichiro KAWASAKI <kawasaki@juno.dti.ne.jp>
Cc: qemu-devel@nongnu.org

On 14:52 Sat 03 Jan     , Shin-ichiro KAWASAKI wrote:
> Shin-ichiro KAWASAKI wrote:
> > Hi, all.
> > 
> > SM501 is a multi function device on sh4/r2d evaluation board.
> > Now, only its minimum graphics feature is implemented.
> > This patch adds SM501's usb host feature.
> > 
> > To use usb keyboard for sh4/r2d system emulation, we need to apply
> > another patch to add PCI usb host.  This patch avoids this work,
> > and provides more precise usb host emultation than PCI one.
> > 
> > Reviews and comments will be appreciated.
> > This patch modifies not only r2d/sm501 related source files but also
> > "hw/usb-ohci.c".  It should not have any impact on other board emulations'
> > usb feature.  Reviews from this point of view will be meaningful.
> 
> I hope the patch to be applied to trunk, because now I believe it has
> no impact for other board emulation, which has PCI usb host or PXA
> usb host.
> 
> I've checked it with following way.
>  - I built sh4/r2d system emulation environment with PCI usb host.
>    Code was taken from qemu svn head and qemu-sh staging quilt repository.
>    And I confirmed that USB keyboard works fine with it.
>  - Applied the SM501 usb host patch to the environment.
>  - Disabled SM501 usb host by killing off following lines in hw/sm501.c
>     /* bridge to usb host emulation module */
>     usb_ohci_init_sm501(base + MMIO_BASE_OFFSET + SM501_USB_HOST, base, 
> 			2, -1, irq);
>  - Booted up the SH-Linux with the environment, and saw how the USB keyboard
>    worked with PCI usb host.
> 
> As a result, PCI usb host works fine under the modification of SM501 usb
> host patch. I didn't checked PXA usb host, but it shares whole codes with
> PCI usb host emulation in "hw/usb-ohci.c".
I agree too

I'll port the usb support on u-boot and test your patch

Best Regards,
J.