From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LLRJ6-0001UR-AW
	for qemu-devel@nongnu.org; Fri, 09 Jan 2009 19:02:28 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LLRJ4-0001UE-Kw
	for qemu-devel@nongnu.org; Fri, 09 Jan 2009 19:02:27 -0500
Received: from [199.232.76.173] (port=56750 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LLRJ4-0001UB-DC
	for qemu-devel@nongnu.org; Fri, 09 Jan 2009 19:02:26 -0500
Received: from mx20.gnu.org ([199.232.41.8]:1331)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1LLRJ3-000175-To
	for qemu-devel@nongnu.org; Fri, 09 Jan 2009 19:02:26 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1LLRJ3-0005Af-44
	for qemu-devel@nongnu.org; Fri, 09 Jan 2009 19:02:25 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option
Date: Fri, 9 Jan 2009 16:02:21 -0800
References: <4967A96B.3020902@eu.citrix.com>
In-Reply-To: <4967A96B.3020902@eu.citrix.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200901091702.22432.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Trolle Selander <trolle.selander@eu.citrix.com>

On Friday 09 January 2009 12:45:47 Trolle Selander wrote:
> +#ifdef TARGET_SPARC
> + =A0 =A0vga_ram_size +=3D (1024 * 1024);
> +#endif

This looks pretty bogus.

> +    if ( vga_ram_size > 16*1024*1024 )
> +    {
> +        fprintf(stderr,"The stdvga/VBE device model currently has no use
> for more than 16 Megs of vram. Video ram reduced to 16M. \n"); +      =20
> vga_ram_size =3D 16*1024*1024;

I'm pretty sure this is wrong. VBE alows arbritary sized virtual framebuffe=
rs.

Paul