From: Riku Voipio <riku.voipio@iki.fi>
To: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [linux-user] Added posix message queue syscalls except mq_notify
Date: Mon, 12 Jan 2009 14:12:35 +0200 [thread overview]
Message-ID: <20090112121235.GA23526@kos.to> (raw)
In-Reply-To: <1229374901.4966.3.camel@cocoduo.atr>
On Mon, Dec 15, 2008 at 10:01:41PM +0100, Lionel Landwerlin wrote:
> + case TARGET_NR_mq_getsetattr:
> + {
> + struct mq_attr posix_mq_attr_in, posix_mq_attr_out;
ret = 0;
> +
> + if (arg3 != 0) {
> + ret = mq_getattr(arg1, &posix_mq_attr_out);
> + copy_to_user_mq_attr(arg3, &posix_mq_attr_out);
> + }
> + if (arg2 != 0) {
> + copy_from_user_mq_attr(&posix_mq_attr_in, arg2);
> + ret |= mq_setattr(arg1, &posix_mq_attr_in, &posix_mq_attr_out);
> + }
> +
> + break;
mq_getsetattr might end up called without both arg3 and arg2. Other than
that, looks good to me.
next prev parent reply other threads:[~2009-01-12 12:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-13 12:39 [Qemu-devel] [linux-user] Added posix message queue syscalls except mq_notify Lionel Landwerlin
2008-12-14 18:11 ` Kirill A. Shutemov
2008-12-14 19:19 ` Lionel Landwerlin
2008-12-14 19:37 ` Kirill A. Shutemov
2008-12-14 20:33 ` Lionel Landwerlin
2008-12-15 21:01 ` Lionel Landwerlin
2008-12-15 21:24 ` Kirill A. Shutemov
2008-12-20 18:20 ` Lionel Landwerlin
2008-12-20 18:33 ` Kirill A. Shutemov
2008-12-20 20:20 ` [Qemu-devel] [PATCH] More strace formatting for posix message queues syscalls Lionel Landwerlin
2008-12-21 13:55 ` [Qemu-devel] " Kirill A. Shutemov
2009-01-12 12:12 ` Riku Voipio [this message]
2009-01-12 12:59 ` [Qemu-devel] [linux-user] Added posix message queue syscalls except mq_notify Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090112121235.GA23526@kos.to \
--to=riku.voipio@iki.fi \
--cc=lionel.landwerlin@openwide.fr \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).