From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LMLf0-0001lR-FC
	for qemu-devel@nongnu.org; Mon, 12 Jan 2009 07:12:50 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LMLev-0001kt-0z
	for qemu-devel@nongnu.org; Mon, 12 Jan 2009 07:12:50 -0500
Received: from [199.232.76.173] (port=55755 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LMLeu-0001kq-To
	for qemu-devel@nongnu.org; Mon, 12 Jan 2009 07:12:44 -0500
Received: from [84.20.150.76] (port=58946 helo=narury.org)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <nchip@kos.to>) id 1LMLeu-0006gs-Gp
	for qemu-devel@nongnu.org; Mon, 12 Jan 2009 07:12:44 -0500
Date: Mon, 12 Jan 2009 14:12:35 +0200
From: Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [linux-user] Added posix message queue syscalls
	except mq_notify
Message-ID: <20090112121235.GA23526@kos.to>
References: <1229171967.3898.59.camel@cocoduo.atr>
	<20081214181152.GC7343@epbyminw8406h.minsk.epam.com>
	<1229374901.4966.3.camel@cocoduo.atr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1229374901.4966.3.camel@cocoduo.atr>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
Cc: qemu-devel@nongnu.org


On Mon, Dec 15, 2008 at 10:01:41PM +0100, Lionel Landwerlin wrote:
> +    case TARGET_NR_mq_getsetattr:
> +    {
> +        struct mq_attr posix_mq_attr_in, posix_mq_attr_out;

ret = 0;

> +
> +        if (arg3 != 0) {
> +            ret = mq_getattr(arg1, &posix_mq_attr_out);
> +            copy_to_user_mq_attr(arg3, &posix_mq_attr_out);
> +        }
> +        if (arg2 != 0) {
> +            copy_from_user_mq_attr(&posix_mq_attr_in, arg2);
> +            ret |= mq_setattr(arg1, &posix_mq_attr_in, &posix_mq_attr_out);
> +        }
> +
> +        break;

mq_getsetattr might end up called without both arg3 and arg2. Other than
that, looks good to me.