From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LNAek-0007tG-Rt
	for qemu-devel@nongnu.org; Wed, 14 Jan 2009 13:39:58 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LNAei-0007sG-WF
	for qemu-devel@nongnu.org; Wed, 14 Jan 2009 13:39:58 -0500
Received: from [199.232.76.173] (port=54701 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LNAei-0007s5-OT
	for qemu-devel@nongnu.org; Wed, 14 Jan 2009 13:39:56 -0500
Received: from mail2.shareable.org ([80.68.89.115]:58577)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <jamie@shareable.org>) id 1LNAei-0000vS-AN
	for qemu-devel@nongnu.org; Wed, 14 Jan 2009 13:39:56 -0500
Received: from jamie by mail2.shareable.org with local (Exim 4.63)
	(envelope-from <jamie@shareable.org>) id 1LNAeh-0002hq-39
	for qemu-devel@nongnu.org; Wed, 14 Jan 2009 18:39:55 +0000
Date: Wed, 14 Jan 2009 18:39:55 +0000
From: Jamie Lokier <jamie@shareable.org>
Subject: Re: [Qemu-devel] [PATCH] Stop VM on ENOSPC error
Message-ID: <20090114183954.GI6431@shareable.org>
References: <20090114120358.GS3267@redhat.com>
	<20090114164717.GC6431@shareable.org>
	<20090114170140.GA4011@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090114170140.GA4011@redhat.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Gleb Natapov wrote:
> On Wed, Jan 14, 2009 at 04:47:17PM +0000, Jamie Lokier wrote:
> > Gleb Natapov wrote:
> > > And repeat last IDE command after VM restart.
> > 
> > If there are multiple AIOs in flight when you get ENOSPC, you may need
> > to repeat all of them.
> > 
> IDE does not support multiple outstanding commands. For SCSI that will have
> to be done though. What my patch is missing is PIO mode support, but this
> should be easy to add.

For some reason I imagined IDE with TCQ(sp?), or SATA with NCQ :-)

What about multiple IDE controllers.  If the VM is stopped (for any
reason, not just ENOSPC) and resumed later, do _other_ controllers'
AIOs in flight need to be replayed?  Are they saved in snapshot state?

-- Jamie