From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNBNW-0003jF-Ps for qemu-devel@nongnu.org; Wed, 14 Jan 2009 14:26:14 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNBNV-0003ha-LO for qemu-devel@nongnu.org; Wed, 14 Jan 2009 14:26:14 -0500 Received: from [199.232.76.173] (port=58447 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNBNV-0003hG-FR for qemu-devel@nongnu.org; Wed, 14 Jan 2009 14:26:13 -0500 Received: from mx2.redhat.com ([66.187.237.31]:59807) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LNBNV-0004ae-3D for qemu-devel@nongnu.org; Wed, 14 Jan 2009 14:26:13 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0EJQC1i018335 for ; Wed, 14 Jan 2009 14:26:12 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n0EJQCHs027109 for ; Wed, 14 Jan 2009 14:26:12 -0500 Received: from dhcp-1-237.tlv.redhat.com (dhcp-1-237.tlv.redhat.com [10.35.1.237]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n0EJQBrf004118 for ; Wed, 14 Jan 2009 14:26:12 -0500 Date: Wed, 14 Jan 2009 21:24:39 +0200 From: Gleb Natapov Subject: Re: [Qemu-devel] [PATCH] Stop VM on ENOSPC error Message-ID: <20090114192439.GA9379@redhat.com> References: <20090114120358.GS3267@redhat.com> <20090114164717.GC6431@shareable.org> <20090114170140.GA4011@redhat.com> <20090114183954.GI6431@shareable.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090114183954.GI6431@shareable.org> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Wed, Jan 14, 2009 at 06:39:55PM +0000, Jamie Lokier wrote: > Gleb Natapov wrote: > > On Wed, Jan 14, 2009 at 04:47:17PM +0000, Jamie Lokier wrote: > > > Gleb Natapov wrote: > > > > And repeat last IDE command after VM restart. > > > > > > If there are multiple AIOs in flight when you get ENOSPC, you may need > > > to repeat all of them. > > > > > IDE does not support multiple outstanding commands. For SCSI that will have > > to be done though. What my patch is missing is PIO mode support, but this > > should be easy to add. > > For some reason I imagined IDE with TCQ(sp?), or SATA with NCQ :-) > But we don't support it yet. > What about multiple IDE controllers. If the VM is stopped (for any > reason, not just ENOSPC) and resumed later, do _other_ controllers' > AIOs in flight need to be replayed? Are they saved in snapshot state? > I think (not sure) vmstop stops only CPU execution, but all outstanding IOs will complete. -- Gleb.