From: Gleb Natapov <gleb@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 2/3] bdrv_write should not stop on partial write.
Date: Thu, 15 Jan 2009 12:12:47 +0200 [thread overview]
Message-ID: <20090115101247.13211.52893.stgit@dhcp-1-237.tlv.redhat.com> (raw)
In-Reply-To: <20090115101241.13211.64596.stgit@dhcp-1-237.tlv.redhat.com>
Should return real error instead.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
---
block.c | 27 ++++++++++++++-------------
1 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/block.c b/block.c
index 28d63d7..3250327 100644
--- a/block.c
+++ b/block.c
@@ -565,21 +565,22 @@ int bdrv_write(BlockDriverState *bs, int64_t sector_num,
if (bs->read_only)
return -EACCES;
if (drv->bdrv_pwrite) {
- int ret, len;
+ int ret, len, count = 0;
len = nb_sectors * 512;
- ret = drv->bdrv_pwrite(bs, sector_num * 512, buf, len);
- if (ret < 0)
- return ret;
- else if (ret != len)
- return -EIO;
- else {
- bs->wr_bytes += (unsigned) len;
- bs->wr_ops ++;
- return 0;
- }
- } else {
- return drv->bdrv_write(bs, sector_num, buf, nb_sectors);
+ do {
+ ret = drv->bdrv_pwrite(bs, sector_num * 512, buf, len - count);
+ if (ret < 0) {
+ printf("bdrv_write ret=%d\n", ret);
+ return ret;
+ }
+ count += ret;
+ buf += ret;
+ } while (count != len);
+ bs->wr_bytes += (unsigned) len;
+ bs->wr_ops ++;
+ return 0;
}
+ return drv->bdrv_write(bs, sector_num, buf, nb_sectors);
}
static int bdrv_pread_em(BlockDriverState *bs, int64_t offset,
next prev parent reply other threads:[~2009-01-15 10:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 10:12 [Qemu-devel] [PATCH v2 1/3] Stop VM on ENOSPC error Gleb Natapov
2009-01-15 10:12 ` Gleb Natapov [this message]
2009-01-15 20:44 ` [Qemu-devel] [PATCH v2 2/3] bdrv_write should not stop on partial write Anthony Liguori
2009-01-15 10:12 ` [Qemu-devel] [PATCH v2 3/3] Return -errno on write failure Gleb Natapov
2009-01-15 20:44 ` Anthony Liguori
2009-01-15 20:39 ` [Qemu-devel] [PATCH v2 1/3] Stop VM on ENOSPC error Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090115101247.13211.52893.stgit@dhcp-1-237.tlv.redhat.com \
--to=gleb@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).