From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LNiwC-0005D8-0H for qemu-devel@nongnu.org; Fri, 16 Jan 2009 02:16:16 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LNiwA-0005CU-3I for qemu-devel@nongnu.org; Fri, 16 Jan 2009 02:16:14 -0500 Received: from [199.232.76.173] (port=51508 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LNiw9-0005CH-UR for qemu-devel@nongnu.org; Fri, 16 Jan 2009 02:16:13 -0500 Received: from mx2.redhat.com ([66.187.237.31]:41165) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LNiw9-0004lF-IJ for qemu-devel@nongnu.org; Fri, 16 Jan 2009 02:16:13 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0G7GCIF027846 for ; Fri, 16 Jan 2009 02:16:12 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n0G7GDbU021049 for ; Fri, 16 Jan 2009 02:16:13 -0500 Received: from dhcp-1-237.tlv.redhat.com (dhcp-1-237.tlv.redhat.com [10.35.1.237]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n0G7GCul008952 for ; Fri, 16 Jan 2009 02:16:12 -0500 Date: Fri, 16 Jan 2009 09:14:37 +0200 From: Gleb Natapov Subject: Re: [Qemu-devel] [PATCH] optionally specify vm stop message Message-ID: <20090116071437.GB27165@redhat.com> References: <20090115103733.GA11299@redhat.com> <496FA08E.4060806@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <496FA08E.4060806@codemonkey.ws> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Thu, Jan 15, 2009 at 02:46:06PM -0600, Anthony Liguori wrote: > Gleb Natapov wrote: >> Should be applied on top of ENOSPC series. >> > > How about just adding a new vm_stop reason? That will work out better > when we introduce the improved monitor. > We may want to specify different message for the same reason. For instance we may want to print the name of the file we failed to write to. Also non zero reasons a handled differently by vm_stop. Don't know why. -- Gleb.