From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LPGiH-00012m-HX
	for qemu-devel@nongnu.org; Tue, 20 Jan 2009 08:32:17 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LPGiG-00011u-T9
	for qemu-devel@nongnu.org; Tue, 20 Jan 2009 08:32:17 -0500
Received: from [199.232.76.173] (port=36313 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LPGiG-00011h-Oj
	for qemu-devel@nongnu.org; Tue, 20 Jan 2009 08:32:16 -0500
Received: from mx2.redhat.com ([66.187.237.31]:46015)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <amit.shah@redhat.com>) id 1LPGiG-0000BR-9T
	for qemu-devel@nongnu.org; Tue, 20 Jan 2009 08:32:16 -0500
Date: Tue, 20 Jan 2009 19:02:28 +0530
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 1/2] Print asynchronous notifications
	on request
Message-ID: <20090120133228.GA1891@amit-x200.pnq.redhat.com>
References: <1232448066-32209-1-git-send-email-amit.shah@redhat.com>
	<4975B6FB.6080302@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4975B6FB.6080302@siemens.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com

On (Tue) Jan 20 2009 [12:35:23], Jan Kiszka wrote:
> Amit Shah wrote:
> > This patch adds the ability to selectively enable asynchronous notifications
> > from individual qemu subsystems by a new 'notify' monitor command.
> > 
> > This is helpful for programs currently parsing monitor output.
> > 
> > A sample invocation will look like this:
> > 
> > (qemu)
> >     <vnc connection closed>
> > (qemu) notify vnc on
> >     <vnc connection closed>
> > (qemu) # VNC: Closing down connection 127.0.0.1:1
> > 
> > Notice that the output is prefixed by '#'. Also, it will appear on the
> > line that has '(qemu) ' already output on it.
> 
> I understand the need, but the result looks a bit ugly, at least to
> humans forced to parse it. If you get this while in the middle of type a
> command... Moreover, is it impossible that such an async notification is
> issued while some other subsystem is already dumping a multi-line
> message to the monitor (using multiple prints)? That would be really
> problematic.

Agreed. However, note that the messages sent via term_printf_async()
will only be emitted if 'notify <foo> on' is issued. Humans wouldn't
normally do that.