From: Alex Williamson <alex.williamson@hp.com>
To: kvm@vger.kernel.org
Cc: markmc@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 5/7] qemu:virtio-net: Enable filtering based on MAC, promisc, broadcast and allmulti
Date: Tue, 20 Jan 2009 14:31:08 -0700 [thread overview]
Message-ID: <20090120212849.3011.19101.stgit@kvm.aw> (raw)
In-Reply-To: <20090116211020.16725.2766.stgit@kvm.aw>
Make use of the new RX_MODE control virtqueue class by dropping
packets the guest doesn't want to see.
Signed-off-by: Alex Williamson <alex.williamson@hp.com>
---
Updated to look past vnet_hdr where necessary.
qemu/hw/virtio-net.c | 28 ++++++++++++++++++++++++++++
1 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/qemu/hw/virtio-net.c b/qemu/hw/virtio-net.c
index d34c299..18877b4 100644
--- a/qemu/hw/virtio-net.c
+++ b/qemu/hw/virtio-net.c
@@ -293,6 +293,31 @@ static int receive_header(VirtIONet *n, struct iovec *iov, int iovcnt,
return offset;
}
+static int receive_filter(VirtIONet *n, const uint8_t *buf, int size)
+{
+ static uint8_t bcast[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
+ uint8_t *ptr = (uint8_t *)buf;
+
+#ifdef TAP_VNET_HDR
+ if (tap_has_vnet_hdr(n->vc->vlan->first_client))
+ ptr += sizeof(struct virtio_net_hdr);
+#endif
+
+ if (n->promisc)
+ return 1;
+
+ if ((ptr[0] & 1) && n->allmulti)
+ return 1;
+
+ if (!memcmp(ptr, bcast, sizeof(bcast)))
+ return 1;
+
+ if (!memcmp(ptr, n->mac, ETH_ALEN))
+ return 1;
+
+ return 0;
+}
+
static void virtio_net_receive(void *opaque, const uint8_t *buf, int size)
{
VirtIONet *n = opaque;
@@ -302,6 +327,9 @@ static void virtio_net_receive(void *opaque, const uint8_t *buf, int size)
if (!do_virtio_net_can_receive(n, size))
return;
+ if (!receive_filter(n, buf, size))
+ return;
+
/* hdr_len refers to the header we supply to the guest */
hdr_len = n->mergeable_rx_bufs ?
sizeof(struct virtio_net_hdr_mrg_rxbuf) : sizeof(struct virtio_net_hdr);
next prev parent reply other threads:[~2009-01-20 21:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 21:09 [Qemu-devel] [PATCH 0/7] qemu:virtio-net: Add MAC and VLAN filtering Alex Williamson
2009-01-16 21:09 ` [Qemu-devel] [PATCH 1/7] qemu:virtio-net: Allow setting the MAC address via set_config Alex Williamson
2009-01-16 21:10 ` [Qemu-devel] [PATCH 2/7] qemu:virtio-net: Define ETH_ALEN for use when manipulating MAC addresses Alex Williamson
2009-01-16 21:10 ` [Qemu-devel] [PATCH 3/7] qemu:virtio-net: Add a virtqueue for control commands from the guest Alex Williamson
2009-01-16 21:10 ` [Qemu-devel] [PATCH 4/7] qemu:virtio-net: Add promiscuous and all-multicast mode bits Alex Williamson
2009-01-16 21:10 ` [Qemu-devel] [PATCH 5/7] qemu:virtio-net: Enable filtering based on MAC, promisc, broadcast and allmulti Alex Williamson
2009-01-20 21:31 ` Alex Williamson [this message]
2009-01-16 21:10 ` [Qemu-devel] [PATCH 6/7] qemu:virtio-net: Add additional MACs via a filter table Alex Williamson
2009-01-20 21:34 ` Alex Williamson
2009-01-16 21:10 ` [Qemu-devel] [PATCH 7/7] qemu:virtio-net: Add VLAN filtering Alex Williamson
2009-01-20 16:45 ` Alex Williamson
2009-01-20 21:38 ` Alex Williamson
2009-01-19 9:45 ` [Qemu-devel] Re: [PATCH 0/7] qemu:virtio-net: Add MAC and " Mark McLoughlin
2009-01-20 2:27 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090120212849.3011.19101.stgit@kvm.aw \
--to=alex.williamson@hp.com \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).