From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LPODm-0004Jc-5p for qemu-devel@nongnu.org; Tue, 20 Jan 2009 16:33:18 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LPODj-0004JE-Oo for qemu-devel@nongnu.org; Tue, 20 Jan 2009 16:33:16 -0500 Received: from [199.232.76.173] (port=41656 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LPODj-0004JB-Hl for qemu-devel@nongnu.org; Tue, 20 Jan 2009 16:33:15 -0500 Received: from g4t0016.houston.hp.com ([15.201.24.19]:3154) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LPODj-0000ot-6j for qemu-devel@nongnu.org; Tue, 20 Jan 2009 16:33:15 -0500 From: Alex Williamson Date: Tue, 20 Jan 2009 14:31:08 -0700 Message-ID: <20090120212849.3011.19101.stgit@kvm.aw> In-Reply-To: <20090116211020.16725.2766.stgit@kvm.aw> References: <20090116211020.16725.2766.stgit@kvm.aw> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH 5/7] qemu:virtio-net: Enable filtering based on MAC, promisc, broadcast and allmulti Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kvm@vger.kernel.org Cc: markmc@redhat.com, qemu-devel@nongnu.org Make use of the new RX_MODE control virtqueue class by dropping packets the guest doesn't want to see. Signed-off-by: Alex Williamson --- Updated to look past vnet_hdr where necessary. qemu/hw/virtio-net.c | 28 ++++++++++++++++++++++++++++ 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/qemu/hw/virtio-net.c b/qemu/hw/virtio-net.c index d34c299..18877b4 100644 --- a/qemu/hw/virtio-net.c +++ b/qemu/hw/virtio-net.c @@ -293,6 +293,31 @@ static int receive_header(VirtIONet *n, struct iovec *iov, int iovcnt, return offset; } +static int receive_filter(VirtIONet *n, const uint8_t *buf, int size) +{ + static uint8_t bcast[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; + uint8_t *ptr = (uint8_t *)buf; + +#ifdef TAP_VNET_HDR + if (tap_has_vnet_hdr(n->vc->vlan->first_client)) + ptr += sizeof(struct virtio_net_hdr); +#endif + + if (n->promisc) + return 1; + + if ((ptr[0] & 1) && n->allmulti) + return 1; + + if (!memcmp(ptr, bcast, sizeof(bcast))) + return 1; + + if (!memcmp(ptr, n->mac, ETH_ALEN)) + return 1; + + return 0; +} + static void virtio_net_receive(void *opaque, const uint8_t *buf, int size) { VirtIONet *n = opaque; @@ -302,6 +327,9 @@ static void virtio_net_receive(void *opaque, const uint8_t *buf, int size) if (!do_virtio_net_can_receive(n, size)) return; + if (!receive_filter(n, buf, size)) + return; + /* hdr_len refers to the header we supply to the guest */ hdr_len = n->mergeable_rx_bufs ? sizeof(struct virtio_net_hdr_mrg_rxbuf) : sizeof(struct virtio_net_hdr);