From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LPhk6-0007Cm-Kv for qemu-devel@nongnu.org; Wed, 21 Jan 2009 13:23:58 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LPhk3-0007BQ-2h for qemu-devel@nongnu.org; Wed, 21 Jan 2009 13:23:58 -0500 Received: from [199.232.76.173] (port=60342 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LPhk2-0007BN-Se for qemu-devel@nongnu.org; Wed, 21 Jan 2009 13:23:54 -0500 Received: from mx1.redhat.com ([66.187.233.31]:48315) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LPhk2-0004SQ-70 for qemu-devel@nongnu.org; Wed, 21 Jan 2009 13:23:54 -0500 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n0LINrT9014104 for ; Wed, 21 Jan 2009 13:23:53 -0500 Received: from file.fab.redhat.com (file.fab.redhat.com [10.33.63.6]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n0LINsob020439 for ; Wed, 21 Jan 2009 13:23:54 -0500 Received: from file.fab.redhat.com (localhost.localdomain [127.0.0.1]) by file.fab.redhat.com (8.13.1/8.13.1) with ESMTP id n0LINqki002632 for ; Wed, 21 Jan 2009 18:23:52 GMT Received: (from berrange@localhost) by file.fab.redhat.com (8.13.1/8.13.1/Submit) id n0LINqML002628 for qemu-devel@nongnu.org; Wed, 21 Jan 2009 18:23:52 GMT Date: Wed, 21 Jan 2009 18:23:52 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option - revised Message-ID: <20090121182351.GB3122@redhat.com> References: <4967A96B.3020902@eu.citrix.com> <4969A57D.2020708@redhat.com> <49776477.4020204@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49776477.4020204@eu.citrix.com> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Wed, Jan 21, 2009 at 01:07:51PM -0500, Trolle Selander wrote: > Hi all, > > This is an updated version of the patch after the suggestions/discussion > on the list. It also includes different handling of how the -vga option > is handled internally, replacing the multiple > independent-yet-mutually-exclusive xxx_vga_enabled variables with one > vgahw_model variable, and also includes the -vga none option added by > Stefano in the time since my last version of this patch. Further > comments & testing welcome. :) > @@ -4933,6 +4930,13 @@ > case QEMU_OPTION_vga: > select_vgahw (optarg); > break; > + case QEMU_OPTION_videoram: > + { > + char *ptr; > + vga_ram_size = strtol(optarg,&ptr,10); > + vga_ram_size *= 1024 * 1024; > + } > + break; > case QEMU_OPTION_g: > { > const char *p; Rather than adding more add hoc extra parameters for VGA tunables, we should just make -vga work like the other generic device args, accepting a optional list comma separated values following it eg -vga cirrus,ram=32 Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|