qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [6391] Fix nographic mode and VNC
Date: Thu, 22 Jan 2009 04:23:22 +0000	[thread overview]
Message-ID: <200901220423.23551.paul@codesourcery.com> (raw)
In-Reply-To: <4977E87A.5040904@codemonkey.ws>

> cpu_exec() spins in a loop checking for 'event_pending'.  This is set
> whenever the host_alarm_timer callback signals.  Alternatively, a halted
> guest will cause cpu_exec() to exit.  Only then do you do a select() on
> pending IO.

Ah, I see.

> If you are using dynticks as your clock, the guest has a slow clock, and
> the guest is not using halt instructions, then you will not poll IO
> until the next guest timer tick b/c your guest is just going to spin.
>
> There are three possible solutions.  Set SIGIO on every file descriptor
> so that TCG breaks whenever IO is pending.  Besides ugliness, this fails
> because not every type of file descriptor supports SIGIO.
>
> A second solution is to use a polling select() in cpu_exec.  Since
> you're adding a system call (and a rather heavy one) in the fast path,
> this is going to likely hurt TCG performance.

This won't work. If the guest really is in a tight loop then TB chaining means 
it will never exit translated code.

> The third possibility is to have the select() run in a separate thread
> from the TCG cpu_exec() loop.  cpu_exec() would do an atomic read of
> 'event_pending' and the IO thread would do an atomic write of
> 'event_pending' whenever select() returned a writable file descriptor.

This suffers from the same problem described above. You need to force the main 
execution thread to break out of the translated loop. In practice this 
probably means sending a signal to the main thread.  You could check 
event_pending at the start of every TB, but that's likely to incur a fairly 
big performance hit.

Paul

  reply	other threads:[~2009-01-22  4:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-21 19:28 [Qemu-devel] [6391] Fix nographic mode and VNC Blue Swirl
2009-01-21 19:39 ` Stefano Stabellini
2009-01-21 19:52   ` Blue Swirl
2009-01-21 19:56     ` Stefano Stabellini
2009-01-21 20:03 ` Samuel Thibault
2009-01-21 20:16   ` Blue Swirl
2009-01-21 20:29     ` Samuel Thibault
2009-01-21 20:44       ` Blue Swirl
2009-01-21 21:33         ` Anthony Liguori
2009-01-22  0:04         ` Paul Brook
2009-01-22  3:31           ` Anthony Liguori
2009-01-22  4:23             ` Paul Brook [this message]
2009-01-22 12:36               ` Ian Jackson
2009-01-23 18:59                 ` Paul Brook
2009-01-22 15:29               ` Anthony Liguori
2009-01-23 18:20                 ` Paul Brook
2009-01-23 19:37                   ` Anthony Liguori
2009-01-25 19:57                   ` Jamie Lokier
2009-01-25 23:25                     ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901220423.23551.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).