From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LQk9l-0006ab-9e for qemu-devel@nongnu.org; Sat, 24 Jan 2009 10:10:45 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LQk9i-0006ZJ-Ux for qemu-devel@nongnu.org; Sat, 24 Jan 2009 10:10:44 -0500 Received: from [199.232.76.173] (port=39456 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LQk9i-0006ZE-NL for qemu-devel@nongnu.org; Sat, 24 Jan 2009 10:10:42 -0500 Received: from mtaout01-winn.ispmail.ntl.com ([81.103.221.47]:32319) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LQk9i-00055v-5u for qemu-devel@nongnu.org; Sat, 24 Jan 2009 10:10:42 -0500 Received: from aamtaout01-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout01-winn.ispmail.ntl.com (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id <20090124151037.AKI2989.mtaout01-winn.ispmail.ntl.com@aamtaout01-winn.ispmail.ntl.com> for ; Sat, 24 Jan 2009 15:10:37 +0000 Received: from miranda.arrow ([213.107.23.205]) by aamtaout01-winn.ispmail.ntl.com (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id <20090124151037.XUQA19264.aamtaout01-winn.ispmail.ntl.com@miranda.arrow> for ; Sat, 24 Jan 2009 15:10:37 +0000 Received: from sdb by miranda.arrow with local (Exim 4.63) (envelope-from ) id 1LQk9b-0007cX-Af for qemu-devel@nongnu.org; Sat, 24 Jan 2009 15:10:35 +0000 Date: Sat, 24 Jan 2009 15:10:35 +0000 From: Stuart Brady Subject: Re: [Qemu-devel] [6380] Make make output quieter (Avi Kivity) Message-ID: <20090124151035.GA29283@miranda.arrow> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Wed, Jan 21, 2009 at 06:13:09PM +0000, Anthony Liguori wrote: > Spew out less noise when compiling. This helps review make output for > information such as compilation warnings, rather than extra long compiler > invocations. > > The full output can be generated by supplying a 'V=1' parameter to make. Excellent! However, I would find it helpful to see the name of the target that is being built. Something like the following? ... Signed-off-by: Stuart Brady Index: rules.mak =================================================================== --- rules.mak (revision 6417) +++ rules.mak (working copy) @@ -1,19 +1,19 @@ %.o: %.c - $(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $<,CC $@) + $(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $<,CC $(TARGET_DIR) $@) %.o: %.S - $(call quiet-command,$(CC) $(CPPFLAGS) -c -o $@ $<,AS $@) + $(call quiet-command,$(CC) $(CPPFLAGS) -c -o $@ $<,AS $(TARGET_DIR) $@) %.o: %.m - $(call quiet-command,$(CC) $(CFLAGS) $(CPPFLAGS) -c -o $@ $<,OBJC $@) + $(call quiet-command,$(CC) $(CFLAGS) $(CPPFLAGS) -c -o $@ $<,OBJC $(TARGET_DIR) $@) -LINK = $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $^ $(LIBS),LINK $@) +LINK = $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $^ $(LIBS),LINK $(TARGET_DIR) $@) %$(EXESUF): %.o $(LINK) %.a: - $(call quiet-command,rm -f $@ && $(AR) rcs $@ $^,AR $@) + $(call quiet-command,rm -f $@ && $(AR) rcs $@ $^,AR $(TARGET_DIR) $@) quiet-command = $(if $(V),$1,@echo $2 && $1) Index: Makefile =================================================================== --- Makefile (revision 6417) +++ Makefile (working copy) @@ -8,6 +8,7 @@ VPATH=$(SRC_PATH):$(SRC_PATH)/hw +TARGET_DIR=common CFLAGS += $(OS_CFLAGS) $(ARCH_CFLAGS) LDFLAGS += $(OS_LDFLAGS) $(ARCH_LDFLAGS) @@ -39,7 +40,7 @@ SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS)) subdir-%: - $(MAKE) -C $(subst subdir-,,$@) V="$(V)" all + $(MAKE) -C $(subst subdir-,,$@) V="$(V)" TARGET_DIR="$*" all $(filter %-softmmu,$(SUBDIR_RULES)): libqemu_common.a $(filter %-user,$(SUBDIR_RULES)): libqemu_user.a Or is there a cleaner way of doing this? (BTW, could the $(subst subdir-,,$@) just be replaced with $*?) Cheers, -- Stuart Brady