[Qemu-devel] [PATCH] Use broadcast address for slirp dhcp replies

[Qemu-devel] [PATCH] Use broadcast address for slirp dhcp replies

[Avi Kivity]

Windows Vista drops unicast dhcp replies to its yet-unconfigured address,
so use a broadcast address.  This behaviour is allowed by the RFC.

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 slirp/bootp.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/slirp/bootp.c b/slirp/bootp.c
index bf704ab..ca177f4 100644
--- a/slirp/bootp.c
+++ b/slirp/bootp.c
@@ -191,6 +191,8 @@ static void bootp_reply(struct bootp_t *bp)
     rbp->bp_yiaddr = daddr.sin_addr; /* Client IP address */
     rbp->bp_siaddr = saddr.sin_addr; /* Server IP address */
 
+    daddr.sin_addr.s_addr = 0xffffffffu;
+
     q = rbp->bp_vend;
     memcpy(q, rfc1533_cookie, 4);
     q += 4;
-- 
1.6.0.6

Re: [Qemu-devel] [PATCH] Use broadcast address for slirp dhcp replies

[Aurelien Jarno]

On Tue, Jan 20, 2009 at 04:33:31PM +0200, Avi Kivity wrote:
> Windows Vista drops unicast dhcp replies to its yet-unconfigured address,
> so use a broadcast address.  This behaviour is allowed by the RFC.
> 
> Signed-off-by: Avi Kivity <avi@redhat.com>

Thanks, applied.

> ---
>  slirp/bootp.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/slirp/bootp.c b/slirp/bootp.c
> index bf704ab..ca177f4 100644
> --- a/slirp/bootp.c
> +++ b/slirp/bootp.c
> @@ -191,6 +191,8 @@ static void bootp_reply(struct bootp_t *bp)
>      rbp->bp_yiaddr = daddr.sin_addr; /* Client IP address */
>      rbp->bp_siaddr = saddr.sin_addr; /* Server IP address */
>  
> +    daddr.sin_addr.s_addr = 0xffffffffu;
> +
>      q = rbp->bp_vend;
>      memcpy(q, rfc1533_cookie, 4);
>      q += 4;
> -- 
> 1.6.0.6
> 
> 
> 
> 

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net