From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LQn3b-00033w-9O for qemu-devel@nongnu.org; Sat, 24 Jan 2009 13:16:35 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LQn3a-00033e-RQ for qemu-devel@nongnu.org; Sat, 24 Jan 2009 13:16:35 -0500 Received: from [199.232.76.173] (port=44483 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LQn3a-00033W-Iq for qemu-devel@nongnu.org; Sat, 24 Jan 2009 13:16:34 -0500 Received: from hall.aurel32.net ([88.191.82.174]:55813) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LQn3a-0001NA-57 for qemu-devel@nongnu.org; Sat, 24 Jan 2009 13:16:34 -0500 Received: from volta.aurel32.net ([2002:52e8:2fb:1:21e:8cff:feb0:693b]) by hall.aurel32.net with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1LQn3Y-00087W-Tq for qemu-devel@nongnu.org; Sat, 24 Jan 2009 19:16:32 +0100 Received: from aurel32 by volta.aurel32.net with local (Exim 4.69) (envelope-from ) id 1LQn3Y-0003j7-9u for qemu-devel@nongnu.org; Sat, 24 Jan 2009 19:16:32 +0100 Date: Sat, 24 Jan 2009 19:16:32 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] Use broadcast address for slirp dhcp replies Message-ID: <20090124181632.GA13698@volta.aurel32.net> References: <1232462011-28073-1-git-send-email-avi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1232462011-28073-1-git-send-email-avi@redhat.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Tue, Jan 20, 2009 at 04:33:31PM +0200, Avi Kivity wrote: > Windows Vista drops unicast dhcp replies to its yet-unconfigured address, > so use a broadcast address. This behaviour is allowed by the RFC. > > Signed-off-by: Avi Kivity Thanks, applied. > --- > slirp/bootp.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/slirp/bootp.c b/slirp/bootp.c > index bf704ab..ca177f4 100644 > --- a/slirp/bootp.c > +++ b/slirp/bootp.c > @@ -191,6 +191,8 @@ static void bootp_reply(struct bootp_t *bp) > rbp->bp_yiaddr = daddr.sin_addr; /* Client IP address */ > rbp->bp_siaddr = saddr.sin_addr; /* Server IP address */ > > + daddr.sin_addr.s_addr = 0xffffffffu; > + > q = rbp->bp_vend; > memcpy(q, rfc1533_cookie, 4); > q += 4; > -- > 1.6.0.6 > > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net