From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org, pavel@pavlinux.ru
Subject: Re: [Qemu-devel] [PATCH] Random MAC address option
Date: Tue, 27 Jan 2009 16:33:48 +0000 [thread overview]
Message-ID: <200901271633.48839.paul@codesourcery.com> (raw)
In-Reply-To: <200901270313.26331.pavel@pavlinux.ru>
> + if (strstr(p, "macrandom")) {
I'm not convinced this is a useful feature.
We already allow the user to specify a mac address, so this feature can be
trivially implemented (and better supported) by a management app or simple
shell script.
In addition to the issues other people have raised, there's no validation that
the random value is actually a valid mac address, and no conflict resolution
to avoid duplicate addresses when multiple NICs are present.
Paul
next prev parent reply other threads:[~2009-01-27 16:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 0:13 [Qemu-devel] [PATCH] Random MAC address option Pavel Vasilyev
2009-01-27 0:34 ` [Qemu-devel] [PATCH] Replace strcmp() by strncmp() Pavel Vasilyev
2009-01-27 9:28 ` [Qemu-devel] " Jan Kiszka
2009-01-27 20:49 ` Pavel Vasilyev
2009-01-27 21:20 ` Pavel Vasilyev
2009-01-27 0:57 ` [Qemu-devel] [PATCH] Random MAC address option malc
2009-01-27 10:05 ` Kevin Wolf
2009-01-27 10:15 ` Riku Voipio
2009-01-27 10:25 ` Daniel P. Berrange
2009-01-27 14:28 ` Ian Jackson
2009-01-27 20:51 ` Pavel Vasilyev
2009-01-27 16:33 ` Paul Brook [this message]
2009-01-27 16:47 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901271633.48839.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=pavel@pavlinux.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).