From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LRqsx-0001bc-08 for qemu-devel@nongnu.org; Tue, 27 Jan 2009 11:33:59 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LRqst-0001WY-5e for qemu-devel@nongnu.org; Tue, 27 Jan 2009 11:33:58 -0500 Received: from [199.232.76.173] (port=53856 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRqss-0001WJ-RU for qemu-devel@nongnu.org; Tue, 27 Jan 2009 11:33:54 -0500 Received: from mx20.gnu.org ([199.232.41.8]:33213) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LRqss-00012O-Iv for qemu-devel@nongnu.org; Tue, 27 Jan 2009 11:33:54 -0500 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LRqsr-0007F2-95 for qemu-devel@nongnu.org; Tue, 27 Jan 2009 11:33:53 -0500 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] Random MAC address option Date: Tue, 27 Jan 2009 16:33:48 +0000 References: <200901270313.26331.pavel@pavlinux.ru> In-Reply-To: <200901270313.26331.pavel@pavlinux.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200901271633.48839.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, pavel@pavlinux.ru > + =A0 =A0 =A0 =A0if (strstr(p, "macrandom")) { I'm not convinced this is a useful feature. We already allow the user to specify a mac address, so this feature can be= =20 trivially implemented (and better supported) by a management app or simple= =20 shell script. In addition to the issues other people have raised, there's no validation t= hat=20 the random value is actually a valid mac address, and no conflict resolutio= n=20 to avoid duplicate addresses when multiple NICs are present. Paul