From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LSAo8-0000Ax-MP
	for qemu-devel@nongnu.org; Wed, 28 Jan 2009 08:50:20 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LSAo6-00009V-1H
	for qemu-devel@nongnu.org; Wed, 28 Jan 2009 08:50:20 -0500
Received: from [199.232.76.173] (port=44658 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LSAo5-00009N-Qz
	for qemu-devel@nongnu.org; Wed, 28 Jan 2009 08:50:17 -0500
Received: from mx20.gnu.org ([199.232.41.8]:8673)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1LSAo5-0008Ip-C5
	for qemu-devel@nongnu.org; Wed, 28 Jan 2009 08:50:17 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1LSAo3-0001UK-Vr
	for qemu-devel@nongnu.org; Wed, 28 Jan 2009 08:50:16 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] expose paravirt feature list to cpuid
Date: Wed, 28 Jan 2009 13:50:09 +0000
References: <1233145351-22380-1-git-send-email-glommer@redhat.com>
In-Reply-To: <1233145351-22380-1-git-send-email-glommer@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200901281350.11132.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Glauber Costa <glommer@redhat.com>, aliguori@us.ibm.com

> +#ifdef KVM_CPUID_SIGNATURE
> +    /* Paravirtualization CPUIDs */
> +    memcpy(signature, "KVMKVMKVM\0\0\0", 12);
> +    pv_ent->ebx = signature[0];
> +    pv_ent->ecx = signature[1];
> +    pv_ent->edx = signature[2];

This is broken on big-endian hosts.

I realise this code is currently only enabled for x86 hosts, however there's a 
good chance we'll want to implement something similar for normal qemu. At 
minimum it needs a comment saying that it's potentially broken.

Paul