From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LSiSC-0004eo-J1 for qemu-devel@nongnu.org; Thu, 29 Jan 2009 20:45:56 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LSiSA-0004ec-9m for qemu-devel@nongnu.org; Thu, 29 Jan 2009 20:45:55 -0500 Received: from [199.232.76.173] (port=35978 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LSiSA-0004eZ-6S for qemu-devel@nongnu.org; Thu, 29 Jan 2009 20:45:54 -0500 Received: from ozlabs.org ([203.10.76.45]:47533) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LSiS9-00025H-1N for qemu-devel@nongnu.org; Thu, 29 Jan 2009 20:45:53 -0500 From: Rusty Russell Date: Fri, 30 Jan 2009 12:15:40 +1030 References: <1233243136-8028-1-git-send-email-markmc@redhat.com> In-Reply-To: <1233243136-8028-1-git-send-email-markmc@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200901301215.40312.rusty@rustcorp.com.au> Subject: [Qemu-devel] Re: [PATCH] virtio-pci: do not oops on config change if driver not loaded Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: linux-kernel@vger.kernel.org, qemu-devel@nongnu.org On Friday 30 January 2009 02:02:16 Mark McLoughlin wrote: > The host really shouldn't be notifying us of config changes > before the device status is VIRTIO_CONFIG_S_DRIVER or > VIRTIO_CONFIG_S_DRIVER_OK. > > However, if we do happen to be interrupted while we're not > attached to a driver, we really shouldn't oops. Thanks, applied! Rusty.