From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Hans-Erik Floryd <hans-erik.floryd@rt-labs.com>
Subject: Re: [Qemu-devel] PL181 write problem
Date: Fri, 30 Jan 2009 14:40:46 +0000 [thread overview]
Message-ID: <200901301440.47265.paul@codesourcery.com> (raw)
In-Reply-To: <4981F759.2040803@rt-labs.com>
> The following patch fixes this by writing all four bytes before checking
> fifo_len.
I think your analysis is probably correct, but I'm not so keen on your
solution. You've got redundant loops/conditions.
Paul
next prev parent reply other threads:[~2009-01-30 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 18:37 [Qemu-devel] PL181 write problem Hans-Erik Floryd
2009-01-30 14:40 ` Paul Brook [this message]
2009-02-02 15:36 ` Hans-Erik Floryd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901301440.47265.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=hans-erik.floryd@rt-labs.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).