[Qemu-devel] [PATCH] Fix signal.c warning

[Qemu-devel] [PATCH] Fix signal.c warning

[Nathan Froyd]

This patch fixes:

/scratch/froydnj/qemu.git/linux-user/signal.c:1403: warning: no previous prototype for 'do_sigreturn_v1'
/scratch/froydnj/qemu.git/linux-user/signal.c:1473: warning: no previous prototype for 'do_sigreturn_v2'
/scratch/froydnj/qemu.git/linux-user/signal.c:1511: warning: no previous prototype for 'do_rt_sigreturn_v1'
/scratch/froydnj/qemu.git/linux-user/signal.c:1552: warning: no previous prototype for 'do_rt_sigreturn_v2'

by making the appropriate functions static.

Signed-off-by: Nathan Froyd <froydnj@codesourcery.com>
---
 linux-user/signal.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/linux-user/signal.c b/linux-user/signal.c
index a468d7a..b7f6f9c 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -1399,7 +1399,7 @@ restore_sigcontext(CPUState *env, struct target_sigcontext *sc)
 	return err;
 }
 
-long do_sigreturn_v1(CPUState *env)
+static long do_sigreturn_v1(CPUState *env)
 {
         abi_ulong frame_addr;
 	struct sigframe_v1 *frame;
@@ -1469,7 +1469,7 @@ static int do_sigframe_return_v2(CPUState *env, target_ulong frame_addr,
     return 0;
 }
 
-long do_sigreturn_v2(CPUState *env)
+static long do_sigreturn_v2(CPUState *env)
 {
         abi_ulong frame_addr;
 	struct sigframe_v2 *frame;
@@ -1507,7 +1507,7 @@ long do_sigreturn(CPUState *env)
     }
 }
 
-long do_rt_sigreturn_v1(CPUState *env)
+static long do_rt_sigreturn_v1(CPUState *env)
 {
         abi_ulong frame_addr;
 	struct rt_sigframe_v1 *frame;
@@ -1548,7 +1548,7 @@ badframe:
 	return 0;
 }
 
-long do_rt_sigreturn_v2(CPUState *env)
+static long do_rt_sigreturn_v2(CPUState *env)
 {
         abi_ulong frame_addr;
 	struct rt_sigframe_v2 *frame;
-- 
1.6.0.5

Re: [Qemu-devel] [PATCH] Fix signal.c warning

[Aurelien Jarno]

On Mon, Jan 26, 2009 at 05:56:10PM -0800, Nathan Froyd wrote:
> This patch fixes:
> 
> /scratch/froydnj/qemu.git/linux-user/signal.c:1403: warning: no previous prototype for 'do_sigreturn_v1'
> /scratch/froydnj/qemu.git/linux-user/signal.c:1473: warning: no previous prototype for 'do_sigreturn_v2'
> /scratch/froydnj/qemu.git/linux-user/signal.c:1511: warning: no previous prototype for 'do_rt_sigreturn_v1'
> /scratch/froydnj/qemu.git/linux-user/signal.c:1552: warning: no previous prototype for 'do_rt_sigreturn_v2'
> 
> by making the appropriate functions static.
> 
> Signed-off-by: Nathan Froyd <froydnj@codesourcery.com>
> ---

Thanks, applied.

>  linux-user/signal.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/linux-user/signal.c b/linux-user/signal.c
> index a468d7a..b7f6f9c 100644
> --- a/linux-user/signal.c
> +++ b/linux-user/signal.c
> @@ -1399,7 +1399,7 @@ restore_sigcontext(CPUState *env, struct target_sigcontext *sc)
>  	return err;
>  }
>  
> -long do_sigreturn_v1(CPUState *env)
> +static long do_sigreturn_v1(CPUState *env)
>  {
>          abi_ulong frame_addr;
>  	struct sigframe_v1 *frame;
> @@ -1469,7 +1469,7 @@ static int do_sigframe_return_v2(CPUState *env, target_ulong frame_addr,
>      return 0;
>  }
>  
> -long do_sigreturn_v2(CPUState *env)
> +static long do_sigreturn_v2(CPUState *env)
>  {
>          abi_ulong frame_addr;
>  	struct sigframe_v2 *frame;
> @@ -1507,7 +1507,7 @@ long do_sigreturn(CPUState *env)
>      }
>  }
>  
> -long do_rt_sigreturn_v1(CPUState *env)
> +static long do_rt_sigreturn_v1(CPUState *env)
>  {
>          abi_ulong frame_addr;
>  	struct rt_sigframe_v1 *frame;
> @@ -1548,7 +1548,7 @@ badframe:
>  	return 0;
>  }
>  
> -long do_rt_sigreturn_v2(CPUState *env)
> +static long do_rt_sigreturn_v2(CPUState *env)
>  {
>          abi_ulong frame_addr;
>  	struct rt_sigframe_v2 *frame;
> -- 
> 1.6.0.5
> 
> 
> 
> 

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net