From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LSzkC-0008DX-73
	for qemu-devel@nongnu.org; Fri, 30 Jan 2009 15:13:40 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LSzkB-0008Cy-Cr
	for qemu-devel@nongnu.org; Fri, 30 Jan 2009 15:13:39 -0500
Received: from [199.232.76.173] (port=35361 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LSzkB-0008Cs-5g
	for qemu-devel@nongnu.org; Fri, 30 Jan 2009 15:13:39 -0500
Received: from hall.aurel32.net ([88.191.82.174]:41411)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1LSzk9-00005N-RU
	for qemu-devel@nongnu.org; Fri, 30 Jan 2009 15:13:39 -0500
Date: Fri, 30 Jan 2009 21:13:29 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] Fix signal.c warning
Message-ID: <20090130201329.GA8917@volta.aurel32.net>
References: <1233021372-15655-1-git-send-email-froydnj@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1233021372-15655-1-git-send-email-froydnj@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: qemu-devel@nongnu.org

On Mon, Jan 26, 2009 at 05:56:10PM -0800, Nathan Froyd wrote:
> This patch fixes:
> 
> /scratch/froydnj/qemu.git/linux-user/signal.c:1403: warning: no previous prototype for 'do_sigreturn_v1'
> /scratch/froydnj/qemu.git/linux-user/signal.c:1473: warning: no previous prototype for 'do_sigreturn_v2'
> /scratch/froydnj/qemu.git/linux-user/signal.c:1511: warning: no previous prototype for 'do_rt_sigreturn_v1'
> /scratch/froydnj/qemu.git/linux-user/signal.c:1552: warning: no previous prototype for 'do_rt_sigreturn_v2'
> 
> by making the appropriate functions static.
> 
> Signed-off-by: Nathan Froyd <froydnj@codesourcery.com>
> ---

Thanks, applied.

>  linux-user/signal.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/linux-user/signal.c b/linux-user/signal.c
> index a468d7a..b7f6f9c 100644
> --- a/linux-user/signal.c
> +++ b/linux-user/signal.c
> @@ -1399,7 +1399,7 @@ restore_sigcontext(CPUState *env, struct target_sigcontext *sc)
>  	return err;
>  }
>  
> -long do_sigreturn_v1(CPUState *env)
> +static long do_sigreturn_v1(CPUState *env)
>  {
>          abi_ulong frame_addr;
>  	struct sigframe_v1 *frame;
> @@ -1469,7 +1469,7 @@ static int do_sigframe_return_v2(CPUState *env, target_ulong frame_addr,
>      return 0;
>  }
>  
> -long do_sigreturn_v2(CPUState *env)
> +static long do_sigreturn_v2(CPUState *env)
>  {
>          abi_ulong frame_addr;
>  	struct sigframe_v2 *frame;
> @@ -1507,7 +1507,7 @@ long do_sigreturn(CPUState *env)
>      }
>  }
>  
> -long do_rt_sigreturn_v1(CPUState *env)
> +static long do_rt_sigreturn_v1(CPUState *env)
>  {
>          abi_ulong frame_addr;
>  	struct rt_sigframe_v1 *frame;
> @@ -1548,7 +1548,7 @@ badframe:
>  	return 0;
>  }
>  
> -long do_rt_sigreturn_v2(CPUState *env)
> +static long do_rt_sigreturn_v2(CPUState *env)
>  {
>          abi_ulong frame_addr;
>  	struct rt_sigframe_v2 *frame;
> -- 
> 1.6.0.5
> 
> 
> 
> 

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net