From: Nathan Froyd <froydnj@codesourcery.com>
To: Alexander Graf <agraf@suse.de>
Cc: "René Rebe" <rene@exactcode.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add multi-boot kernel loading support
Date: Mon, 2 Feb 2009 10:25:01 -0800 [thread overview]
Message-ID: <20090202182501.GC15286@codesourcery.com> (raw)
In-Reply-To: <498738AE.6080808@suse.de>
On Mon, Feb 02, 2009 at 07:17:18PM +0100, Alexander Graf wrote:
> Nathan Froyd wrote:
> > On Mon, Feb 02, 2009 at 07:08:00PM +0100, Rene Rebe wrote:
> >> + /* 660f011528000000 lgdt [0x28] */
> >> + *p++ = 0x66; /* 32-bit operand size */
> >> + *p++ = 0x67; /* 32-bit addr size */
> >> + *p++ = 0x0f; /* LGDT [0x128] */
> >> + *p++ = 0x01;
> >> + *p++ = 0x15;
> >> + pgdt=p; /* we calculate the gdt position later */
> >> + p+=4;
> >>
> >
> > The comments do not appear to agree with the code here. (The operands
> > for lgdt are different, at the very least.)
>
> Right, because the operands are actually calculated dynamically. Any
> suggestions on how to improve that? Maybe LGDT [GDT]?
Yes, I think that would be an improvement. Editing the bytestring to
reflect that would be good, as well.
-Nathan
next prev parent reply other threads:[~2009-02-02 18:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 18:08 [Qemu-devel] [PATCH] Add multi-boot kernel loading support Rene Rebe
2009-02-02 18:15 ` Nathan Froyd
2009-02-02 18:17 ` Alexander Graf
2009-02-02 18:25 ` Nathan Froyd [this message]
2009-02-02 22:42 ` Anthony Liguori
2009-02-03 8:15 ` Rene Rebe
2009-02-03 8:23 ` Alexander Graf
2009-02-03 8:27 ` Rene Rebe
2009-02-03 8:25 ` Alexander Graf
2009-02-03 8:29 ` Rene Rebe
2009-02-03 10:53 ` Jamie Lokier
2009-02-03 11:12 ` Alexander Graf
2009-02-03 12:58 ` Kevin Wolf
2009-02-03 13:57 ` Rene Rebe
2009-02-03 14:31 ` Kevin Wolf
2009-02-04 10:36 ` Rene Rebe
2009-02-04 13:05 ` Kevin Wolf
2009-02-03 13:01 ` Paul Brook
2009-02-03 14:00 ` Rene Rebe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090202182501.GC15286@codesourcery.com \
--to=froydnj@codesourcery.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=rene@exactcode.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).