From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LUIud-0000bm-Th
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 05:53:51 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LUIuc-0000Za-DH
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 05:53:51 -0500
Received: from [199.232.76.173] (port=58452 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LUIuc-0000ZS-6w
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 05:53:50 -0500
Received: from mail2.shareable.org ([80.68.89.115]:47174)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <jamie@shareable.org>) id 1LUIub-0007fs-SD
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 05:53:50 -0500
Date: Tue, 3 Feb 2009 10:53:39 +0000
From: Jamie Lokier <jamie@shareable.org>
Subject: Re: [Qemu-devel] [PATCH] Add multi-boot kernel loading support
Message-ID: <20090203105339.GC11926@shareable.org>
References: <49873680.2040603@exactcode.de> <498776EC.1050208@codemonkey.ws>
	<D84C730F-64D3-48FA-A467-256583B9803C@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <D84C730F-64D3-48FA-A467-256583B9803C@suse.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: =?iso-8859-1?Q?Ren=E9?= Rebe <rene@exactcode.de>

Alexander Graf wrote:
> >>--- elf_ops.h    (revision 6501)
> >>+++ elf_ops.h    (working copy)
> >>@@ -195,6 +195,10 @@
> >>    }
> >>
> >>    if (ELF_MACHINE != ehdr.e_machine)
> >>+#if (ELF_MACHINE == EM_X86_64) && !defined(CONFIG_USER_ONLY)
> >>+      /* x86_64 systems can run i386 code as well */
> >>+      if(ehdr.e_machine != EM_386)
> >>+#endif
> >>        goto fail;
> >>
> >>    if (pentry)
> >
> >Seems like an unrelated fix.
> 
> Actually it's not. If you want to load a 32-bit elf (multiboot)  
> executable on an x86_64 system, you need this patch.

Why CONFIG_USER_ONLY?

Does it mean qemu-x86_64 (the user one) will behave differently given
a 32-bit ELF file if you built qemu-system-x86_64 at the same time?

-- Jamie