From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LULKd-0006Ha-H3 for qemu-devel@nongnu.org; Tue, 03 Feb 2009 08:28:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LULKZ-0006FQ-FQ for qemu-devel@nongnu.org; Tue, 03 Feb 2009 08:28:50 -0500 Received: from [199.232.76.173] (port=39582 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LULKZ-0006F7-4a for qemu-devel@nongnu.org; Tue, 03 Feb 2009 08:28:47 -0500 Received: from mx1.redhat.com ([66.187.233.31]:37026) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LULKW-0006sP-Vr for qemu-devel@nongnu.org; Tue, 03 Feb 2009 08:28:46 -0500 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n13DSge3002845 for ; Tue, 3 Feb 2009 08:28:42 -0500 Received: from file.fab.redhat.com (file.fab.redhat.com [10.33.63.6]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n13DShG0016668 for ; Tue, 3 Feb 2009 08:28:44 -0500 Received: from file.fab.redhat.com (localhost.localdomain [127.0.0.1]) by file.fab.redhat.com (8.13.1/8.13.1) with ESMTP id n13DSfKf015008 for ; Tue, 3 Feb 2009 13:28:41 GMT Received: (from berrange@localhost) by file.fab.redhat.com (8.13.1/8.13.1/Submit) id n13DSfgQ015004 for qemu-devel@nongnu.org; Tue, 3 Feb 2009 13:28:41 GMT Date: Tue, 3 Feb 2009 13:28:41 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] QEMU SVN on Windows 2000 :-( Message-ID: <20090203132841.GB15613@redhat.com> References: <49876B4C.9090806@bttr-software.de> <498773B6.7060301@codemonkey.ws> <4987F7F1.2040104@redhat.com> <49883914.2030904@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49883914.2030904@codemonkey.ws> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Tue, Feb 03, 2009 at 06:31:16AM -0600, Anthony Liguori wrote: > Avi Kivity wrote: > >Anthony Liguori wrote: > >>Robert Riebisch wrote: > >>>Hi! > >>> > >>>Unfortunately Win32 binaries built from QEMU SVN don't run on Windows > >>>2000 anymore, because of missing DLL entry points in `ws2_32.dll'. > >>> > >> > >>Unfortunately, win2k is so old at this point, that I don't know that > >>it's worth jumping through hoops to support. > >> > >>If someone can come up with a simple patch (with appropriately > >>licensed code), then I'd be happy to apply it. Otherwise, I don't > >>think not supporting win2k as a host is a huge loss. > >> > > > >There is in fact a signed-off two-liner still in the thread: > > "but it requires copyrighted file `Wspiapi.h' from MSVC2005, because > MinGW doesn't provide such a file." > > So if Wspiapi.h carries a GPL compatible license, it's fine to include. > The patch lacks Wspiapi.h though so it'll break the build on mingw. Well MinGW already builds fine with getaddrinfo(), so no need for a GPL header providing Wspiapi.h there. Since this is only needed for a few Win builds, why not just make the include conditional on whether that header actually exists. eg #ifdef HAVE_WSPIAPI_H #include #endif Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|