From: Aurelien Jarno <aurelien@aurel32.net>
To: Stuart Brady <stuart.brady@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix compilation of PPC64 targets with DEBUG_TCGV enabled
Date: Tue, 3 Feb 2009 20:57:08 +0100 [thread overview]
Message-ID: <20090203195708.GD18984@volta.aurel32.net> (raw)
In-Reply-To: <20090131182125.GA11704@miranda.arrow>
On Sat, Jan 31, 2009 at 06:21:25PM +0000, Stuart Brady wrote:
> The attached patch fixes compilation of PPC64 targets with DEBUG_TCGV
> enabled.
>
> Signed-off-by: Stuart Brady <stuart.brady@gmail.com>
Thanks, applied.
> Index: target-ppc/translate.c
> ===================================================================
> --- target-ppc/translate.c (revision 6489)
> +++ target-ppc/translate.c (working copy)
> @@ -6263,7 +6263,7 @@
> t = tcg_temp_new_i32();
> tcg_gen_ld_i32(t, cpu_env, offsetof(CPUState, vscr));
> tcg_gen_extu_i32_i64(cpu_avrl[rD(ctx->opcode)], t);
> - tcg_temp_free(t);
> + tcg_temp_free_i32(t);
> }
>
> GEN_HANDLER(mtvscr, 0x04, 0x2, 0x19, 0x03ff0000, PPC_ALTIVEC)
> @@ -6511,7 +6511,7 @@
> GEN_HANDLER(vsldoi, 0x04, 0x16, 0xFF, 0x00000400, PPC_ALTIVEC)
> {
> TCGv_ptr ra, rb, rd;
> - TCGv sh;
> + TCGv_i32 sh;
> if (unlikely(!ctx->altivec_enabled)) {
> gen_exception(ctx, POWERPC_EXCP_VPU);
> return;
> @@ -6524,7 +6524,7 @@
> tcg_temp_free_ptr(ra);
> tcg_temp_free_ptr(rb);
> tcg_temp_free_ptr(rd);
> - tcg_temp_free(sh);
> + tcg_temp_free_i32(sh);
> }
>
> #define GEN_VAFORM_PAIRED(name0, name1, opc2) \
> --
> Stuart Brady
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2009-02-03 19:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 18:21 [Qemu-devel] [PATCH] Fix compilation of PPC64 targets with DEBUG_TCGV enabled Stuart Brady
2009-02-03 19:57 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090203195708.GD18984@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=stuart.brady@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).