From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LURyf-0002Km-5S
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 15:34:37 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LURyd-0002KL-LJ
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 15:34:36 -0500
Received: from [199.232.76.173] (port=32829 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LURyd-0002KG-Ew
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 15:34:35 -0500
Received: from mx20.gnu.org ([199.232.41.8]:30705)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <froydnj@codesourcery.com>)
	id 1LURyd-0002J7-6R
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 15:34:35 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <froydnj@codesourcery.com>) id 1LURyc-0005vo-7R
	for qemu-devel@nongnu.org; Tue, 03 Feb 2009 15:34:34 -0500
Date: Tue, 3 Feb 2009 12:34:33 -0800
From: Nathan Froyd <froydnj@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 07/14] Add v{add,sub}fp instructions
Message-ID: <20090203203433.GE15286@codesourcery.com>
References: <1232657054-30100-1-git-send-email-froydnj@codesourcery.com>
	<1232657054-30100-8-git-send-email-froydnj@codesourcery.com>
	<20090203195248.GC18984@volta.aurel32.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090203195248.GC18984@volta.aurel32.net>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On Tue, Feb 03, 2009 at 08:52:48PM +0100, Aurelien Jarno wrote:
> On Thu, Jan 22, 2009 at 12:44:07PM -0800, Nathan Froyd wrote:
> > +void helper_vsubfp (ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)
> > +{
> > +    int i;
> > +    for (i = 0; i < ARRAY_SIZE(r->f); i++) {
> > +        HANDLE_NAN2(r->f[i], a->f[i], b->f[i]) {
> > +            if (unlikely(float32_is_infinity(a->f[i]) &&
> > +                         float32_is_infinity(b->f[i]) &&
> > +                         float32_is_neg(a->f[i]) == float32_is_neg(b->f[i]))) {
> > +                /* Magnitude subtraction of infinities */
> > +                r->u32[i] = 0x7fc00000;
> 
> I think this case is already handled by the softfloat code.

Ah, hm, I think you may be right.  That's what I get for cargo-culting
the code from the existing float helpers. :)

This means I don't have to separate v{add,sub}fp, either.  I'll resubmit
this one; I don't think any of the other patches in the series will
conflict.

-Nathan