From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LUgrU-0001EC-U2 for qemu-devel@nongnu.org; Wed, 04 Feb 2009 07:28:12 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LUgrS-0001C6-5P for qemu-devel@nongnu.org; Wed, 04 Feb 2009 07:28:12 -0500 Received: from [199.232.76.173] (port=39712 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUgrR-0001Bv-TS for qemu-devel@nongnu.org; Wed, 04 Feb 2009 07:28:09 -0500 Received: from mail2.shareable.org ([80.68.89.115]:45006) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LUgrR-00085f-9U for qemu-devel@nongnu.org; Wed, 04 Feb 2009 07:28:09 -0500 Date: Wed, 4 Feb 2009 12:28:05 +0000 From: Jamie Lokier Subject: Re: [Qemu-devel] QEMU SVN on Windows 2000 :-( Message-ID: <20090204122804.GA8111@shareable.org> References: <49876B4C.9090806@bttr-software.de> <498773B6.7060301@codemonkey.ws> <4987F7F1.2040104@redhat.com> <49883914.2030904@codemonkey.ws> <20090203132841.GB15613@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090203132841.GB15613@redhat.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Daniel P. Berrange wrote: > > "but it requires copyrighted file `Wspiapi.h' from MSVC2005, because > > MinGW doesn't provide such a file." > > > > So if Wspiapi.h carries a GPL compatible license, it's fine to include. > > The patch lacks Wspiapi.h though so it'll break the build on mingw. > > Well MinGW already builds fine with getaddrinfo(), so no need for a GPL > header providing Wspiapi.h there. Since this is only needed for a few > Win builds, why not just make the include conditional on whether that > header actually exists. eg It should compile, but the point is it will fail at run time on most versions of Windows 2000, and all earlier Windows versions. Imho it's standard practice on Windows to look up getaddrinfo() dynamically, in case it doesn't exist - same for a few other functions. But maybe that's just my standard practice ;-) Windows XP was introduced in 2003, iirc, about the same time as Linux 2.6.0, although major distributions didn't pick up Linux 2.6 until years later. Does Qemu run on Linux 2.4? -- Jamie