From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LUrVO-0006LI-Mr for qemu-devel@nongnu.org; Wed, 04 Feb 2009 18:50:06 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LUrVK-0006J8-WD for qemu-devel@nongnu.org; Wed, 04 Feb 2009 18:50:06 -0500 Received: from [199.232.76.173] (port=54020 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUrVK-0006J4-Qp for qemu-devel@nongnu.org; Wed, 04 Feb 2009 18:50:02 -0500 Received: from mx20.gnu.org ([199.232.41.8]:52996) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LUrVK-0006os-HU for qemu-devel@nongnu.org; Wed, 04 Feb 2009 18:50:02 -0500 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LUrVJ-0004uY-0l for qemu-devel@nongnu.org; Wed, 04 Feb 2009 18:50:01 -0500 From: Paul Brook Subject: Re: [Qemu-devel] Re: [PATCH 1/4] Add a scatter-gather list type and accessors Date: Wed, 4 Feb 2009 23:49:56 +0000 References: <1233750314-23301-1-git-send-email-avi@redhat.com> <1233750314-23301-2-git-send-email-avi@redhat.com> <4989EC29.9050705@us.ibm.com> In-Reply-To: <4989EC29.9050705@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902042349.57668.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Avi Kivity > > + if (qsg->nsg == qsg->nalloc) { > > + qsg->nalloc = 2 * qsg->nalloc + 1; > > Do you really want exponential growth verses linear growth? The sg > lists should be relatively small so linear growth should be fine. If they're small it shouldn't make a any real difference... Paul